Changeset 4419

Timestamp:

10/24/06 10:52:59 (2 years ago)

Author:

markjaquith

Message:

Fix post meta caching system to reduce queries and eliminate redundant WP code. fixes #3273

Files:

• trunk/wp-includes/functions.php (modified) (1 diff)
• trunk/wp-includes/post.php (modified) (3 diffs)

trunk/wp-includes/functions.php

@@ -564 +564 @@
-    update_post_category_cache($post_id_list);
-
+    update_postmeta_cache($post_id_list);
+}
+
+function update_postmeta_cache($post_id_list = '') {
+    global $wpdb, $post_meta_cache;
+
+    // We should validate this comma-separated list for the upcoming SQL query
+    $post_id_list = preg_replace('|[^0-9,]|', '', $post_id_list);
+
+    // we're marking each post as having its meta cached (with no keys... empty array), to prevent posts with no meta keys from being queried again
+    // any posts that DO have keys will have this empty array overwritten with a proper array, down below
+    $post_id_array = explode(',', $post_id_list);
+    foreach ( (array) $post_id_array as $pid )
+        $post_meta_cache[$pid] = array();
+
-    // Get post-meta info
-    if ( $meta_list = $wpdb->get_results("SELECT post_id, meta_key, meta_value FROM $wpdb->postmeta WHERE post_id IN($post_id_list) ORDER BY post_id, meta_key", ARRAY_A) ) {
-        // Change from flat structure to hierarchical:
-
+
+
+
-        foreach ($meta_list as $metarow) {
-            $mpid = (int) $metarow['post_id'];

trunk/wp-includes/post.php

@@ -275 +275 @@
-    $post_id = (int) $post_id;
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
-
-    if ( $single ) {
-count($values) ) {
-$return = maybe_unserialize( $values[0] 
-} else {
+isset($post_meta_cache[$post_id][$key][0]) )
+return maybe_unserialize($post_meta_cache[$post_id][$key][0]
+else
-            return '';
-
-
-
-
-
-
+
+
+
-}
-
@@ -341 +324 @@
-
-
- $post_id = 0 
+$post_id = 0
-    global $id, $post_meta_cache, $wpdb;
-
- 
+
-        $post_id = $id;
-
-    $post_id = (int) $post_id;
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
-}
-
@@ -377 +341 @@
-    $custom = get_post_custom( $post_id );
-
- 
+
-        return;
-