Changeset 8208

Show
Ignore:
Timestamp:
06/27/08 20:14:50 (4 months ago)
Author:
ryan
Message:

Check fopen return value. Props Otto42 and pishmishy. fixes #4448

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/wp-admin/theme-editor.php

    r7979 r8208  
    4444    $theme = urlencode($theme); 
    4545    if (is_writeable($real_file)) { 
     46        //is_writable() not always reliable, check return value. see comments @ http://uk.php.net/is_writable 
    4647        $f = fopen($real_file, 'w+'); 
    47         fwrite($f, $newcontent); 
    48         fclose($f); 
    49         $location = "theme-editor.php?file=$file&theme=$theme&a=te"; 
     48        if ($f !== FALSE) { 
     49            fwrite($f, $newcontent); 
     50            fclose($f); 
     51            $location = "theme-editor.php?file=$file&theme=$theme&a=te"; 
     52        } else { 
     53            $location = "theme-editor.php?file=$file&theme=$theme"; 
     54        } 
    5055    } else { 
    5156        $location = "theme-editor.php?file=$file&theme=$theme";