Changeset 8944

Show
Ignore:
Timestamp:
09/21/08 20:41:25 (2 months ago)
Author:
westi
Message:

Notice fixes see #7509 props DD32 and jacobsantos.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/wp-admin/categories.php

    r8923 r8944  
    1414wp_reset_vars(array('action', 'cat')); 
    1515 
    16 if ( $_GET['action'] == 'delete' && isset($_GET['delete']) ) 
     16if ( isset( $_GET['action'] ) && $_GET['action'] == 'delete' && isset($_GET['delete']) ) 
    1717    $action = 'bulk-delete'; 
    1818 
    …… 
    155155 
    156156<?php 
    157 $pagenum = absint( $_GET['pagenum'] ); 
     157$pagenum = isset( $_GET['pagenum'] ) ? absint( $_GET['pagenum'] ) : 0; 
    158158if ( empty($pagenum) ) 
    159159    $pagenum = 1; 
    160 if( !$catsperpage || $catsperpage < 0 ) 
     160if( ! isset( $catsperpage ) || $catsperpage < 0 ) 
    161161    $catsperpage = 20; 
    162162 

  • trunk/wp-admin/edit-category-form.php

    r8656 r8944  
    66 * @subpackage Administration 
    77 */ 
     8 
     9/** 
     10 * @var object 
     11 */ 
     12if ( ! isset( $category ) ) 
     13    $category = (object) array(); 
    814 
    915if ( ! empty($cat_ID) ) { 
    …… 
    2531    do_action('add_category_form_pre', $category); 
    2632} 
     33 
     34/** 
     35 * @ignore 
     36 * @since 2.7 
     37 * @internal Used to prevent errors in page when no category is being edited. 
     38 * 
     39 * @param object $category 
     40 */ 
     41function _fill_empty_category(&$category) { 
     42    if ( ! isset( $category->name ) ) 
     43        $category->name = ''; 
     44 
     45    if ( ! isset( $category->slug ) ) 
     46        $category->slug = ''; 
     47 
     48    if ( ! isset( $category->parent ) ) 
     49        $category->parent = ''; 
     50 
     51    if ( ! isset( $category->description ) ) 
     52        $category->description = ''; 
     53} 
     54 
     55_fill_empty_category($category); 
    2756?> 
    2857 

  • trunk/wp-admin/edit-form-advanced.php

    r8893 r8944  
    370370</p> 
    371371<h4><?php _e( 'Post Password' ); ?></h4> 
    372 <p><label class="hidden" for="post_password"><?php _e('Password Protect This Post') ?></label><input name="post_password" type="text" size="25" id="post_password" value="<?php echo attribute_escape( $post->post_password ); ?>" /></p> 
     372<p><label class="hidden" for="post_password"><?php _e('Password Protect This Post') ?></label><input name="post_password" type="text" size="25" id="post_password" value="<?php if ( isset( $post->post_password ) ) echo attribute_escape( $post->post_password ); ?>" /></p> 
    373373<p><?php _e('Setting a password will require people who visit your blog to enter the above password to view this post and its comments.'); ?></p> 
    374374<?php 

  • trunk/wp-admin/edit-link-categories.php

    r8923 r8944  
    9696 
    9797<?php 
    98 $pagenum = absint( $_GET['pagenum'] ); 
     98$pagenum = isset( $_GET['pagenum'] ) ? absint( $_GET['pagenum'] ) : 0; 
    9999if ( empty($pagenum) ) 
    100100    $pagenum = 1; 
    101 if( !$catsperpage || $catsperpage < 0 ) 
     101if( ! isset( $catsperpage ) || $catsperpage < 0 ) 
    102102    $catsperpage = 20; 
    103103 

  • trunk/wp-admin/edit-link-category-form.php

    r8656 r8944  
    66 * @subpackage Administration 
    77 */ 
     8 
     9/** 
     10 * @var object 
     11 */ 
     12if ( ! isset( $category ) ) 
     13    $category = (object) array(); 
    814 
    915if ( ! empty($cat_ID) ) { 
    …… 
    2531    do_action('add_link_category_form_pre', $category); 
    2632} 
     33 
     34/** 
     35 * @ignore 
     36 * @since 2.7 
     37 * @internal Used to prevent errors in page when no category is being edited. 
     38 * 
     39 * @param object $category 
     40 */ 
     41function _fill_empty_link_category(&$category) { 
     42    if ( ! isset( $category->name ) ) 
     43        $category->name = ''; 
     44 
     45    if ( ! isset( $category->slug ) ) 
     46        $category->slug = ''; 
     47 
     48    if ( ! isset( $category->description ) ) 
     49        $category->description = ''; 
     50} 
     51 
     52_fill_empty_link_category($category); 
    2753?> 
    2854 

  • trunk/wp-admin/edit-tag-form.php

    r8656 r8944  
    3737        <tr class="form-field form-required"> 
    3838            <th scope="row" valign="top"><label for="name"><?php _e('Tag name') ?></label></th> 
    39             <td><input name="name" id="name" type="text" value="<?php echo attribute_escape($tag->name); ?>" size="40" aria-required="true" /> 
     39            <td><input name="name" id="name" type="text" value="<?php if ( isset( $tag->name ) ) echo attribute_escape($tag->name); ?>" size="40" aria-required="true" /> 
    4040            <p><?php _e('The name is how the tag appears on your site.'); ?></p></td> 
    4141        </tr> 
    4242        <tr class="form-field"> 
    4343            <th scope="row" valign="top"><label for="slug"><?php _e('Tag slug') ?></label></th> 
    44             <td><input name="slug" id="slug" type="text" value="<?php echo attribute_escape(apply_filters('editable_slug', $tag->slug)); ?>" size="40" /> 
     44            <td><input name="slug" id="slug" type="text" value="<?php if ( isset( $tag->slug ) ) echo attribute_escape(apply_filters('editable_slug', $tag->slug)); ?>" size="40" /> 
    4545            <p><?php _e('The &#8220;slug&#8221; is the URL-friendly version of the name. It is usually all lowercase and contains only letters, numbers, and hyphens.'); ?></p></td> 
    4646        </tr> 

  • trunk/wp-admin/edit-tags.php

    r8930 r8944  
    1414wp_reset_vars(array('action', 'tag')); 
    1515 
    16 if ( $_GET['action'] == 'delete' && isset($_GET['delete_tags']) ) 
     16if ( isset( $_GET['action'] ) && $_GET['action'] == 'delete' && isset($_GET['delete_tags']) ) 
    1717    $action = 'bulk-delete'; 
    1818 
    …… 
    162162 
    163163<?php 
    164 $pagenum = absint( $_GET['pagenum'] ); 
     164$pagenum = isset( $_GET['pagenum'] ) ? absint( $_GET['pagenum'] ) : 0; 
    165165if ( empty($pagenum) ) 
    166166    $pagenum = 1; 
    167 if( !$tagsperpage || $tagsperpage < 0 ) 
     167if( ! isset( $tagsperpage ) || $tagsperpage < 0 ) 
    168168    $tagsperpage = 20; 
    169169 
    …… 
    202202<?php 
    203203 
    204 $searchterms = trim( $_GET['s'] ); 
     204$searchterms = isset( $_GET['s'] ) ? trim( $_GET['s'] ) : ''; 
    205205 
    206206$count = tag_rows( $pagenum, $tagsperpage, $searchterms ); 

  • trunk/wp-admin/includes/user.php

    r8701 r8944  
    231231    $user->display_name = attribute_escape($user->display_name); 
    232232    $user->nickname     = attribute_escape($user->nickname); 
    233     $user->aim          = attribute_escape($user->aim); 
    234     $user->yim          = attribute_escape($user->yim); 
    235     $user->jabber       = attribute_escape($user->jabber); 
    236     $user->description  = wp_specialchars($user->description); 
     233    $user->aim          = isset( $user->aim ) && !empty( $user->aim ) ? attribute_escape($user->aim) : ''; 
     234    $user->yim          = isset( $user->yim ) && !empty( $user->yim ) ? attribute_escape($user->yim) : ''; 
     235    $user->jabber       = isset( $user->jabber ) && !empty( $user->jabber ) ? attribute_escape($user->jabber) : ''; 
     236    $user->description  = isset( $user->description ) && !empty( $user->description ) ? wp_specialchars($user->description) : ''; 
    237237 
    238238    return $user; 

  • trunk/wp-admin/includes/widgets.php

    r8912 r8944  
    6060                continue; 
    6161 
     62            if ( ! isset( $widget['params'][0] ) ) 
     63                $widget['params'][0] = array(); 
    6264            ob_start(); 
    63                $args = wp_list_widget_controls_dynamic_sidebar( array( 0 => array( 'widget_id' => $widget['id'], 'widget_name' => $widget['name'], '_display' => 'template', '_show' => $show ), 1 => $widget['params'][0] ) ); 
    64                $sidebar_args = call_user_func_array( 'wp_widget_control', $args ); 
     65            $args = wp_list_widget_controls_dynamic_sidebar( array( 0 => array( 'widget_id' => $widget['id'], 'widget_name' => $widget['name'], '_display' => 'template', '_show' => $show ), 1 => $widget['params'][0] ) ); 
     66            $sidebar_args = call_user_func_array( 'wp_widget_control', $args ); 
    6567            $widget_control_template = ob_get_contents(); 
    6668            ob_end_clean(); 
    …… 
    231233 
    232234    $id_format = $widget['id']; 
     235 
     236    if ( ! isset( $sidebar_args['_show'] ) ) 
     237        $sidebar_args['_show'] = ''; 
     238 
     239    if ( ! isset( $sidebar_args['_display'] ) ) 
     240        $sidebar_args['_display'] = ''; 
     241 
    233242    // We aren't showing a widget control, we're outputing a template for a mult-widget control 
    234243    if ( 'all' == $sidebar_args['_show'] && 'template' == $sidebar_args['_display'] && isset($control['params'][0]['number']) ) { 

  • trunk/wp-admin/menu.php

    r8905 r8944  
    125125        } 
    126126        unset($submenu[$old_parent]); 
    127         $_wp_submenu_nopriv[$new_parent] = $_wp_submenu_nopriv[$old_parent]; 
     127 
     128        if ( isset($_wp_submenu_nopriv[$old_parent]) ) 
     129            $_wp_submenu_nopriv[$new_parent] = $_wp_submenu_nopriv[$old_parent]; 
    128130    } 
    129131} 

  • trunk/wp-admin/upload.php

    r8901 r8944  
    178178    // Use $_GET instead of is_ since they can override each other 
    179179    $h2_author = ''; 
    180     $_GET['author'] = (int) $_GET['author']; 
     180    $_GET['author'] = isset( $_GET['author'] ) ? (int) $_GET['author'] : 0; 
    181181    if ( $_GET['author'] != 0 ) { 
    182182        if ( $_GET['author'] == '-' . $user_ID ) { // author exclusion 

  • trunk/wp-admin/user-edit.php

    r8845 r8944  
    158158</div> 
    159159<?php endif; ?> 
    160 <?php if ( is_wp_error( $errors ) ) : ?> 
     160<?php if ( isset( $errors ) && is_wp_error( $errors ) ) : ?> 
    161161<div class="error"> 
    162162    <ul> 

  • trunk/wp-includes/feed.php

    r8800 r8944  
    495495function self_link() { 
    496496    echo 'http' 
    497         . ( $_SERVER['https'] == 'on' ? 's' : '' ) . '://' 
     497        . ( (isset($_SERVER['https']) && $_SERVER['https'] == 'on') ? 's' : '' ) . '://' 
    498498        . $_SERVER['HTTP_HOST'] 
    499499        . wp_specialchars(stripslashes($_SERVER['REQUEST_URI']), 1); 

  • trunk/wp-includes/functions.php

    r8784 r8944  
    803803function make_url_footnote( $content ) { 
    804804    preg_match_all( '/<a(.+?)href=\"(.+?)\"(.*?)>(.+?)<\/a>/', $content, $matches ); 
    805     $j = 0; 
     805    $links_summary = "\n"; 
    806806    for ( $i=0; $i<count($matches[0]); $i++ ) { 
    807         $links_summary = ( !$j ) ? "\n" : $links_summary; 
    808         $j++; 
    809807        $link_match = $matches[0][$i]; 
    810808        $link_number = '['.($i+1).']'; 

  • trunk/wp-includes/taxonomy.php

    r8782 r8944  
    716716        $cache[ $key ] = array(); 
    717717        wp_cache_set( 'get_terms', $cache, 'terms' ); 
    718         return apply_filters('get_terms', array(), $taxonomies, $args); 
     718        $terms = apply_filters('get_terms', array(), $taxonomies, $args); 
     719        return $terms; 
    719720    } 
    720721