Ticket #1076 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

is_seach logic in default theme which has search.php template

Reported by: MC_incubus Assigned to: mdawaffe
Priority: normal Milestone: 2.1
Component: Template Version: 1.5
Severity: trivial Keywords: has-patch commit template
Cc:

Description

in the default 1.5 (kubrick) theme, in the archives.php template, there is this:

<?php /* If this is a search */ } elseif (is_search()) { ?>

<h2 class="pagetitle">Search Results</h2>

But because there is a search.php template, all is_search() true requests should go there, so this logic does nothing in archives.php

Hat tip to dmclark in #wordpress for finding this

Attachments

1076.diff (0.7 kB) - added by mdawaffe on 08/31/06 21:00:52.

Change History

03/10/05 21:15:48 changed by MC_incubus

  • Patch set to No.

08/31/06 21:00:52 changed by mdawaffe

  • attachment 1076.diff added.

08/31/06 21:01:37 changed by mdawaffe

  • keywords set to has-patch commit template.
  • owner changed from anonymous to mdawaffe.
  • status changed from new to assigned.
  • milestone set to 2.1.

Patched.

09/07/06 00:25:50 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4166]) Remove is_search() check that will never be reached. fixes #1076