Ticket #1257 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Pingbacks sent from wrong URI for posts first published in advanced editing mode

Reported by: mdawaffe Assigned to: markjaquith
Priority: normal Milestone:
Component: General Version: 1.5.1.1
Severity: major Keywords: bg|has-patch bg|commit
Cc:

Description

Publishing a post from advanced editing mode will, if it is the first time the post has been published, send pingbacks from non-permalinked URIs: http://example.com/?p=204 rather than http://example.com/a-post/

Attachments

fix-permalink-in-outgoing-pings.diff (1.3 kB) - added by markjaquith on 08/23/05 09:08:07.
Patch for /branches/1.5/

Change History

04/19/05 02:15:27 changed by mdawaffe

  • Patch set to No.

05/10/05 16:39:18 changed by ryan

In 1.5.1, draft posts are not given a permalink GUID since the post slug is not set on a draft post. Instead, a query string GUID is used. Once pubilshed, the GUID should be updated so that a proper permalink-style GUID is used. The GUID life cycle should be similar to the post slug lifecycle. Leave the GUID blank for draft posts. Set the GUID once published.

05/23/05 23:33:45 changed by markjaquith

  • version changed from 1.5.1 to 1.5.1.1.

This issue persists in 1.5.1.1

06/23/05 19:56:05 changed by ryan

  • owner changed from anonymous to ryan.
  • milestone set to 1.6.

07/06/05 05:18:56 changed by markjaquith

  • keywords set to bg|needs-patch.
  • severity changed from minor to major.

07/26/05 23:49:26 changed by bennettmcelwee

The cause of this problem is the cache mechanism used in get_post(). I created the FixBack WordPress plugin to fix this problem, but of course a core change would be more elegant. See WordPress pingback and trackback bug for full details.

08/23/05 09:08:07 changed by markjaquith

  • attachment fix-permalink-in-outgoing-pings.diff added.

Patch for /branches/1.5/

08/23/05 11:45:35 changed by markjaquith

  • keywords changed from bg|needs-patch to bg|has-patch bg|commit.
  • owner changed from ryan to markjaquith.
  • status changed from new to assigned.

I've been sitting on this patch (was posted to wp-hackers). Really sorry that I didn't get it uploaded in time for 1.5.2! Anyway, let's be sure to get it into the next 1.5 branch release.

08/30/05 04:10:02 changed by ryan

Can we move this code into functions? Perhaps clean_post_cache() and clean_page_cache() which take a post/page ID as an argument. Call these whenever we update a post/page.

09/14/05 00:34:06 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [2873]) Add clean_post_cache() and clean_page_cache(). Reset GUID when transitioning from draft to publish. fixes #1257

11/30/06 19:41:47 changed by

  • milestone deleted.

Milestone 2.0 deleted