Ticket #1452 (closed defect: worksforme)

Opened 3 years ago

Last modified 1 year ago

Trackback not working with XML-RPC

Reported by: pombsd Assigned to: ryan
Priority: normal Milestone:
Component: XML-RPC Version: 1.5.1.2
Severity: normal Keywords: trackback xmlrpc has-patch
Cc:

Description

Using WordPress 1.5.1.2 for testing purposes I discovered that outgoing trackbacks are not correctly handled by the XML-RPC interface. I'm using MarsEdit to edit my posts.

MarsEdit sends its list of trackback URIs as an array following the form: <value> <array> <data> <value><string>http://my.trackback.url</string></value> </data> </array> </value> Now WordPress seems to expect a comma-separated list of URIs. I don't know which one is the preferred behaviour here, but I do know that WordPress does only save a string named "Array" as a single URI. This happens, when I add new and edit existing posts (mw_newPost() and mw_editPost() in xmlrpc.php).

The second issue is that when editing a post (method mw_editPost() in xmlrpc.php), the ID gets lost. It magically reverts back to 1 during the update (line 617 in xmlrpc.php), but is still used for sending out trackback URIs later on.

Attachments

xmlrpc.php.patch (1.6 kB) - added by pombsd on 06/18/05 21:31:48.
Patch for both bugs mentioned

Change History

06/18/05 21:31:48 changed by pombsd

  • attachment xmlrpc.php.patch added.

Patch for both bugs mentioned

06/18/05 21:33:20 changed by pombsd

The attached patch fixes both bugs in the simplest way I could come up with. Trackbacks work with MarsEdit now, but should also the way intended (?) with a comma-separated list of trackback URIs. The ID doesn't get lost anymore, as well.

06/19/05 03:34:31 changed by ryan

Your solution works, although I fixed it a bit differently in [2653]. I passed the space separated trackback list to wp_insert_post() and wp_update_post() in the to_ping argument instead of to trackback_url_list(). insert and update know what to do with the trackbacks.

06/20/05 01:24:45 changed by ryan

  • owner changed from anonymous to ryan.
  • version changed from 1.5.2 to 1.5.1.2.
  • milestone set to 1.6.

07/07/05 19:01:36 changed by pombsd

Just wanted to note that this still does not work in 1.5.1.3, although your bugfix seems to be included. Seems to me as if trackback URLs coming in as arrays still aren't handled correctly.

11/25/05 22:57:51 changed by matt

  • milestone changed from 2.0 to 2.1.

08/14/06 19:58:01 changed by rgovostes

  • keywords changed from trackback xmlrpc to trackback xmlrpc has-patch.

11/29/06 22:48:12 changed by matt

  • status changed from new to closed.
  • resolution set to worksforme.

06/23/07 12:08:25 changed by Nazgul

  • milestone deleted.