Ticket #1494 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Spurious notices about $HTTP_RAW_POST_DATA

Reported by: mgeisler Assigned to: anonymous
Priority: normal Milestone:
Component: XML-RPC Version: 1.5.1.2
Severity: normal Keywords: has-patch
Cc:

Description

I'm seeing spurious notices from PHP about $HTTP_RAW_POST_DATA not being defined:

PHP Notice: Undefined variable: HTTP_RAW_POST_DATA in /home/mgeisler/mgeisler.net/html/xmlrpc.php on line 4

I guess one could wrap the line in a if(isset($HTTP_RAW_POST_DATA)) and at the same time move the call to logIO("I", $HTTP_RAW_POST_DATA) up in the same wrapping.

Or maybe it would be better to post-pone this processing to class-IXR.php since xmlrpc.php doesn't really use $HTTP_RAW_POST_DATA.

Attachments

1494.diff (343 bytes) - added by Nazgul on 10/04/06 01:06:03.

Change History

10/04/06 01:06:03 changed by Nazgul

  • attachment 1494.diff added.

10/04/06 01:07:54 changed by Nazgul

  • keywords set to has-patch.
  • milestone set to 2.1.

The first reference to HTTP_RAW_POST_DATA is already guarded by an isset in trunk.

Patch attached which does the same for the second reference to HTTP_RAW_POST_DATA.

10/04/06 04:52:01 changed by Nazgul

  • milestone changed from 2.1 to 2.0.5.

2.0.5 Candidate

10/04/06 05:23:12 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [4305]) avoid $HTTP_RAW_POST_DATA notices. props mgeisler and Nazgul. fixes #1494

10/04/06 05:23:24 changed by markjaquith

(In [4306]) avoid $HTTP_RAW_POST_DATA notices. props mgeisler and Nazgul. fixes #1494

11/30/06 19:41:51 changed by

  • milestone deleted.

Milestone 2.0.5 deleted