Ticket #1532 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

wp_notify_postauthor() sends pingback/trackback e-mails from bad address

Reported by: markjaquith Assigned to: markjaquith
Priority: normal Milestone:
Component: Administration Version: 1.5.1.2
Severity: normal Keywords: bg|has-patch bg|commit
Cc:

Description

wp_notify_postauthor() sends pingback and trackback notification e-mails from wordpress@$_SERVERSERVER_NAME?

The problem is that on some hosts, $_SERVERSERVER_NAME? is in the form of www.domain.com instead of just domain.com

These wordpress@www.domain.com e-mails are getting deleted somewhere along the line as obviously bogus.

We need to check for leading www. and strip it out.

Attachments

bug1532.diff (0.8 kB) - added by graeme on 11/06/05 08:17:05.
email_from_wordpress_at_domain.diff (1.6 kB) - added by markjaquith on 11/17/05 07:19:54.
Email sent from wordpress@domain (with "www." stripped)

Change History

11/06/05 08:17:05 changed by graeme

  • attachment bug1532.diff added.

11/06/05 08:17:17 changed by graeme

  • owner changed from anonymous to graeme.

11/07/05 02:42:26 changed by graeme

  • keywords changed from bg|needs-patch to bg|2nd-opinion.

11/07/05 05:03:37 changed by graeme

  • keywords changed from bg|2nd-opinion to bg|2nd-opinion bg|has-patch.

11/13/05 03:33:39 changed by matt

  • keywords changed from bg|2nd-opinion bg|has-patch to bg|2nd-opinion.

This doesn't really fix the core problem though, what should we send system generated mails out as from:? In other parts of the code we use admin email.

11/17/05 07:19:54 changed by markjaquith

  • attachment email_from_wordpress_at_domain.diff added.

Email sent from wordpress@domain (with "www." stripped)

11/17/05 07:21:34 changed by markjaquith

  • keywords changed from bg|2nd-opinion to bg|has-patch bg|commit.
  • owner changed from graeme to markjaquith.
  • status changed from new to assigned.

Final decision was that wordpress@domain is best, because admin email might be from off-domain and might be more likely to get flagged as spam at its destination.

11/25/05 22:57:27 changed by matt

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [3214]) Better email from, fixes #1532

11/30/06 19:41:47 changed by

  • milestone deleted.

Milestone 2.0 deleted