Ticket #1541 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Pingback source URIs are no longer checked for a valid link (!!!)

Reported by: markjaquith Assigned to: markjaquith
Priority: highest omg bbq Milestone:
Component: Administration Version: 1.6
Severity: critical Keywords: bg|has-patch bg|commit
Cc:

Description

In both 1.6 SVN and /branches/1.5/, pingback "from" URIs are no longer checked to see if they have a valid link!

This change happened when Denis' improved excerpt code was inserted. The old code was taken out... including the part that verifies that the link exists.

This definitely needs to get fixed before a 1.5.1.4 release is made from the 1.5 code branch, or Pingback will suddenly be as wide open as Trackback to spammers. How do you think I discovered this bug? ;-)

Attachments

xmlrpc.php_1.5-branch.diff (0.5 kB) - added by markjaquith on 07/29/05 00:45:09.
Patch for 1.5 branch
xmlrpc.php_1.6-svn.diff (0.5 kB) - added by markjaquith on 07/29/05 00:45:28.
Patch for 1.6 SVN

Change History

07/29/05 00:34:17 changed by markjaquith

  • status changed from new to assigned.

07/29/05 00:34:25 changed by markjaquith

  • milestone changed from 2.0 to 1.6.

07/29/05 00:45:09 changed by markjaquith

  • attachment xmlrpc.php_1.5-branch.diff added.

Patch for 1.5 branch

07/29/05 00:45:28 changed by markjaquith

  • attachment xmlrpc.php_1.6-svn.diff added.

Patch for 1.6 SVN

07/29/05 00:46:09 changed by markjaquith

  • keywords changed from bg|dev-feedback bg|needs-patch to bg|has-patch bg|commit.

07/29/05 00:46:46 changed by markjaquith

  • summary changed from Pingback URIs are no longer validated (!!) to Pingback source URIs are no longer checked for a valid link (!!!).

08/03/05 00:30:40 changed by matt

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [2742]) Fixes #1541

08/11/05 20:26:45 changed by markjaquith

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 1.6 to 1.5.2.

Okay, fixed for 1.6, but we still need this in /branches/1.5/ for that 1.5.2 release.

08/12/05 07:07:53 changed by matt

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [2778]) Re fixes #1541

11/30/06 19:41:47 changed by

  • milestone deleted.

Milestone 1.5.2 deleted