Ticket #1708 (closed defect: worksforme)

Opened 3 years ago

Last modified 3 years ago

Typo with $object->property statements causes PHP5 to give fatal errors.

Reported by: splee Assigned to: anonymous
Priority: high Milestone:
Component: General Version: 1.5
Severity: major Keywords: php5 compatibility bg|squashed
Cc:

Description

I have attached diffs for both the 1.5 tag and the trunk code.

PHP 5.0.5 gives the following error when get_settings() from wp-includes/functions.php is run under certain conditions (reproducable in the manage->tags page when the UltimateTagWarrior? plugin is installed):

Fatal error: Cannot access empty property in /path/to/root/wp-includes/functions.php on line 246

Attachments

1.5-object-property-typo.txt (0.6 kB) - added by splee on 09/26/05 10:19:21.
patch for the 1.5 branch
trunk-object-property-typo.txt (0.5 kB) - added by splee on 09/26/05 10:21:07.
patch for the trunk

Change History

09/26/05 10:19:21 changed by splee

  • attachment 1.5-object-property-typo.txt added.

patch for the 1.5 branch

09/26/05 10:21:07 changed by splee

  • attachment trunk-object-property-typo.txt added.

patch for the trunk

09/26/05 10:38:35 changed by splee

  • priority changed from normal to high.
  • severity changed from normal to major.

09/26/05 15:56:25 changed by westi

  • keywords changed from php5 compatibility to php5 compatibility bg|has-patch.

11/05/05 03:47:36 changed by masquerade

I believe this bug is invalid.

A) UTW has been known to be broken in 1.6, looks like there are a few compatability checkins lately, try the latest version? B) Even if this is a bug with WP, this is far from a proper fix, and this will break many other things. C) I can't duplicate the problem

11/05/05 03:54:35 changed by masquerade

  • status changed from new to closed.
  • resolution set to worksforme.

Got MarkJaquith? to try, couldn't duplicate either.

11/05/05 03:54:50 changed by masquerade

  • keywords changed from php5 compatibility bg|has-patch to php5 compatibility bg|squashed.