Ticket #1785 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

Atom-based comment feed

Reported by: kurtmckee Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: General Version: 2.1
Severity: normal Keywords: has-patch needs-testing dev-feedback
Cc: rboren

Description

I've created an Atom 0.3 comment feed. Holizz (holizz.com) updated the code to be Atom 1.0 compliant. It is coded against WordPress 1.5.2.

Attachments

wp-commentsatom.php (3.7 kB) - added by kurtmckee on 10/24/05 00:04:24.
wp-commentsatom.2.php (3.8 kB) - added by kurtmckee on 10/24/05 02:29:06.
Fixed incorrect xml:base and id output
1785.diff (5.2 kB) - added by rob1n on 02/23/07 05:51:18.

Change History

10/24/05 00:04:24 changed by kurtmckee

  • attachment wp-commentsatom.php added.

10/24/05 02:29:06 changed by kurtmckee

  • attachment wp-commentsatom.2.php added.

Fixed incorrect xml:base and id output

11/06/05 09:49:38 changed by davidhouse

  • keywords changed from atom comments feed to atom comments feed bg|has-patch.

11/13/05 03:05:49 changed by matt

  • priority changed from normal to low.
  • milestone changed from 1.6 to 2.1.

08/10/06 13:21:02 changed by _ck_

  • priority changed from low to normal.

Note for the wp-commentsatom.php to work correctly with rewritten urls in Wordpress 2.x this function has to be updated to the following in wp-includes/functions.php 

function do_feed_atom($for_comments) {
if ( $for_comments ) {
load_template(ABSPATH . 'wp-commentsatom.php');
} else {
load_template(ABSPATH . 'wp-atom.php');
}
}

Wordpress is WAY overdue to have working ATOM 1.0 feeds and it's super easy to add into the next alpha release with all the groundword already done.

11/29/06 22:58:28 changed by matt

  • milestone changed from 2.1 to 2.2.

02/22/07 06:45:01 changed by rob1n

  • keywords changed from atom comments feed bg|has-patch to dev-feedback.
  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.

Is this something that the devs want in the core?

Also, the patch is outdated. I can work on a new one.

02/23/07 00:40:01 changed by rob1n

Waiting on feedback.

02/23/07 00:40:13 changed by rob1n

(Out-of-Trac feedback)

02/23/07 02:53:40 changed by ryan

Add the template as wp-includes/feed-atom-comments.php.

Update do_feed_atom() to handle withcomments.

Update do_feed() to not assume comment feeds are always rss2.

02/23/07 04:03:22 changed by rob1n

  • keywords deleted.
  • version changed from 1.6 to 2.1.

I'm on it. :)

02/23/07 05:51:18 changed by rob1n

  • attachment 1785.diff added.

02/23/07 05:52:11 changed by rob1n

  • cc set to rboren.
  • keywords set to has-patch needs-testing dev-feedback.

Added preliminary patch that NEEDS looking over. I *believe* I did everything right, but then again...

02/23/07 06:02:36 changed by rob1n

Okay, I found one error already: I use bloginfo_rss('content_type') instead of bloginfo_rss('html_type'). I'll fix this in the morning.

02/23/07 08:18:33 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4928]) Atom comments feed. First pass. Props kurtmckee and rob1n. fixes #1785