Ticket #1936 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Ugly bland error message upon missing wp-config file ... and a fix!

Reported by: chuyskywalker Assigned to: markjaquith
Priority: normal Milestone: 2.1
Component: Administration Version: 1.6
Severity: normal Keywords: has-patch commit
Cc:

Description

I was going through the 2.0 beta1 to give it a run and after SNV CO'ing the files I just hit the website and got this ugly, no frills, plain, and scary error message about some missing files and some such.

So, doing my part, here's a patch that snatches the same layout as the database error screen and uses it to pretty up this error. Additionally, I added some basic write checks to see if a user can even use the setup-config.php before offering them the false hope that it'd work.

Finally, I've updated the "more help" link to point to the much more complete and helpful codex wp-config reference.

Attachments

nicer-no-config.diff (2.6 kB) - added by chuyskywalker on 11/22/05 06:15:49.
patch to make the ugly error not so ugly, and much more helpful
1936.diff (2.5 kB) - added by Nazgul on 10/04/06 00:07:47.
missing_wp-config.patch (2.4 kB) - added by Viper007Bond on 12/01/06 13:48:45.
missing_wp-config.2.patch (2.4 kB) - added by Viper007Bond on 12/01/06 13:50:19.

Change History

11/22/05 06:15:49 changed by chuyskywalker

  • attachment nicer-no-config.diff added.

patch to make the ugly error not so ugly, and much more helpful

11/22/05 06:21:19 changed by chuyskywalker

  • keywords set to bg|has-patch.

11/25/05 22:50:25 changed by matt

  • milestone changed from 2.0 to 2.1.

10/04/06 00:07:47 changed by Nazgul

  • attachment 1936.diff added.

10/04/06 00:08:26 changed by Nazgul

  • keywords changed from bg|has-patch to has-patch.

Updated the patch to make use of wp_die.

10/04/06 04:55:59 changed by Nazgul

  • milestone changed from 2.1 to 2.0.5.

2.0.5. Candidate

10/04/06 05:31:57 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.
  • milestone changed from 2.0.5 to 2.1.

wp_die() is 2.1 only.

10/04/06 05:32:21 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4307]) missing wp-config.php error uses wp_die() now. props Nazgul. fixes #1936

12/01/06 13:48:34 changed by Viper007Bond

  • status changed from closed to reopened.
  • resolution deleted.

Needs some more work.

12/01/06 13:48:45 changed by Viper007Bond

  • attachment missing_wp-config.patch added.

12/01/06 13:50:19 changed by Viper007Bond

  • attachment missing_wp-config.2.patch added.

12/01/06 13:50:52 changed by Viper007Bond

Bah, forgot to check the "overwrite" box.

12/02/06 22:33:54 changed by matt

  • milestone changed from 2.1 to 2.2.

(follow-up: ↓ 11 ) 12/03/06 01:33:02 changed by Viper007Bond

Why is changing the help link to the Codex something that should wait for 2.2?

(in reply to: ↑ 10 ) 01/06/07 01:13:07 changed by foolswisdom

  • keywords changed from has-patch to has-patch commit.
  • milestone changed from 2.2 to 2.1.

Replying to Viper007Bond:

Why is changing the help link to the Codex something that should wait for 2.2?

Because this ticket has become epic? ;-) But lets try again. Setting milestone to 2.1 . Please apply missing_wp-config.2.patch

epic: started out with a detailed problem and creative and complete solution by chuyskywalker, later Nazgul lay down a tight fix... time passed... Viper reopened for the missing important pieces, but the tale was probably forgotten. I often do the same thing, but I do try to remember that we have lots of ticket numbers available.

01/16/07 01:42:09 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [4737]) Change editing wp-config codex link. fixes #1936