Ticket #2131 (closed defect: fixed)

Opened 3 years ago

Last modified 10 months ago

RTE align buttons use deprecated HTML attributes

Reported by: seth Assigned to: anonymous
Priority: high Milestone: 2.5
Component: TinyMCE Version: 2.0
Severity: major Keywords: xhtml
Cc:

Description

When using the align buttons, they generate markup like: 

<p align="center"></p>

It would be much better to have them use the style attribute: 

<p style="text-align: center"></p>

Change History

12/23/05 01:30:06 changed by skeltoac

  • priority changed from normal to low.
  • milestone set to 2.5.

07/09/06 14:34:04 changed by darkfate

Is this still valid for 2.0.3?

09/21/06 02:17:36 changed by foolswisdom

  • keywords set to xhtml.
  • summary changed from WYSIWYG align buttons use invalid markup to RTE align buttons use invalid markup.
  • component changed from Administration to General.
  • milestone changed from 2.5 to 2.2.

ENV: WP 2.1-alpha3 (r4198)

Yes, darkfate, using RTE, this still seems as described.

seth, what do you mean by "invalid markup"?

01/26/07 03:37:35 changed by kccricket

  • summary changed from RTE align buttons use invalid markup to RTE align buttons use deprecated HTML attributes.

It would be better to say that they use deprecated HTML attributes.

See: http://www.w3.org/TR/html4/present/graphics.html#adef-align

01/26/07 05:57:53 changed by foolswisdom

Relates to #3618

02/24/07 00:09:41 changed by Nazgul

  • component changed from General to TinyMCE.

02/26/07 03:27:12 changed by JeremyVisser

No, it's invalid markup in XHTML 1.0 Strict (and XHTML 1.1, etc.). Most themes use XHTML 1.0 Transitional and the align attribute is only deprecated in Transitional.

03/24/07 17:57:03 changed by rob1n

  • priority changed from low to high.
  • severity changed from normal to major.

03/26/07 22:36:33 changed by foolswisdom

#1607 , #3618 closed as dup of this ticket.

04/10/07 18:30:22 changed by foolswisdom

  • milestone changed from 2.2 to 2.3.

04/19/07 00:40:02 changed by johnbillion

Note that the left/center/right align buttons have a different effect when used on images instead of paragraphs.

The align="left" attribute works like style="float:left" instead of style="text-align:left" and the same goes for the right-align button (with float:right obviously). This will need to be taken into consideration if this issue is to be fixed.

04/19/07 00:41:51 changed by johnbillion

What I mean to say is, when the left/right button is used on an image, the HTML which is inserted will need to be different (style="float:left" instead of style="text-align:left").

09/06/07 21:39:23 changed by Nazgul

Reported upstream: text-align bug and image float bug

09/12/07 17:42:27 changed by ryan

  • milestone changed from 2.3 to 2.4 (next).

12/31/07 02:16:21 changed by thee17

  • milestone changed from 2.4 to 2.5.

Still not addressed by TinyMCE tickets submitted by Nazgul should be pushed.

01/06/08 16:52:39 changed by thee17

  • milestone changed from 2.6 to 2.5.

brought back incase gets addressed before march

01/24/08 17:54:23 changed by Nazgul

Maybe fixed by #5674. Needs testing when that ticket matures.

01/25/08 04:31:42 changed by thee17

  • status changed from new to closed.
  • resolution set to fixed.

Works! TinyMCE 3.0 fixed it.