Ticket #2180 (closed defect: fixed)

Opened 3 years ago

Last modified 1 year ago

Closed comments doesn't surround the output of comments_popup_link with a class

Reported by: Michael Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: Template Version: 2.0
Severity: normal Keywords: has-patch commit
Cc:

Description

When using comments_popup_link, the fourth parameter sets the class of the link around the comments. However, if the comments are closed on an entry, no class is set. It would perhaps be preferable if there was a 'before' and 'after' parameter set, so one could surround the comment with a span or something similar.

Attachments

2180.diff (503 bytes) - added by rob1n on 03/31/07 23:00:15.

Change History

03/31/07 23:00:15 changed by rob1n

  • attachment 2180.diff added.

03/31/07 23:01:52 changed by rob1n

  • keywords changed from comments "comments_popup_link" "template tag" to has-patch 2nd-opinion.
  • owner changed from anonymous to rob1n.
  • milestone set to 2.2.

Any thoughts? I'm impartial, really.

03/31/07 23:24:37 changed by Nazgul

From a user point of view I'm impartial as well.

From a programmers point of view I'm in favor of this patch. I have the option to pass a css class to the function, which then isn't used consistently. That seems counter-intuitive.

04/01/07 00:32:48 changed by rob1n

I agree.

04/01/07 00:34:20 changed by rob1n

  • keywords changed from has-patch 2nd-opinion to has-patch commit.

04/01/07 15:57:16 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5165]) Add CSS class in if it's not empty when there's no comments. fixes #2180