Ticket #2288 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Reenable cache for safe_mode hosts

Reported by: Juergen Assigned to: anonymous
Priority: normal Milestone:
Component: General Version: 2.0
Severity: normal Keywords:
Cc:

Description

Changeset 3436 disabled the cache when safe_mode is enabled. Why? It seems to work fine with a proper setup (manually created cache dir, proper dir permissions and safe_mode settings).

Attachments

2288.diff (0.5 kB) - added by davidhouse on 01/16/06 21:40:29.

Change History

01/15/06 10:11:12 changed by davidhouse

  • keywords set to bg|2nd-opinion bg|dev-feedback.

Agreed, there shouldn't be a blanket condition there. Could we change 

if (ini_get('safe_mode'))

to 

if (ini_get('safe_mode') && get_option('safe_mode_no_cache'))

Then people with safe mode, who knew what they were doing, could just pop over to wp-admin/options.php (we wouldn't display this option by default in the admin) and change it to true?

01/15/06 11:01:59 changed by ryan

We could have ENABLE_CACHE be a force-enable flag that skips the safe_mode check.

01/15/06 11:03:46 changed by ryan

BTW, you can't use get_option() in the cache because the cache is loaded and initialized before everything except $wpdb.

01/16/06 21:40:29 changed by davidhouse

  • attachment 2288.diff added.

01/16/06 21:41:01 changed by davidhouse

  • keywords changed from bg|2nd-opinion bg|dev-feedback to bg|2nd-opinion bg|dev-feedback bg|has-patch.

Thanks for that info. Patch attached.

01/22/06 21:35:02 changed by markjaquith

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 2.0.1.

Fixed by [3462] 

define('ENABLE_CACHE', true'); // put this in wp-config.php to force the cache to be on

11/30/06 19:41:49 changed by

  • milestone deleted.

Milestone 2.0.1 deleted