Ticket #2485 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

No flexibility in comments RSS feed

Reported by: mdawaffe Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: General Version: 2.1
Severity: normal Keywords: has-patch needs-testing
Cc: coppit

Description

wp-commentsrss2.php does not give any flexibility in determining what sorts of comments should be displayed. All we get is the feed for individual posts/pages or for the whole site. Additionally, no filtration is allowed.

The attached hangs on the coat tails of WP_Query. Comment feeds for time, category, search, post, page, and the main site should all work. Filtration on JOIN and WHERE is allowed.

I've not done any benchmarking comparing this patch vs. the old system.

Attachments

commentfeed.diff (8.0 kB) - added by mdawaffe on 02/19/06 23:03:01.
Allows for more flexibility in comment feeds
2485.diff (9.5 kB) - added by rob1n on 02/24/07 00:25:06.
2485.2.diff (11.8 kB) - added by rob1n on 02/24/07 00:59:29.
Adds have_comment(), the_comment and a bunch of WP_Query stuff, including the original patch. *needs testing*
2485.3.diff (16.2 kB) - added by mdawaffe on 02/24/07 02:03:44.

Change History

02/19/06 23:03:01 changed by mdawaffe

  • attachment commentfeed.diff added.

Allows for more flexibility in comment feeds

02/19/06 23:19:02 changed by mdawaffe

Oops. Here's how to access the comment feeds supplied by this patch:

http://wp.example.com/category/some-cat/feed/?withcomments=1 http://wp.example.com/2005/12/feed/?withcomments=1 http://wp.example.com/?s=term&feed=1&withcomments=1

06/07/06 16:40:45 changed by coppit

  • cc set to coppit.

08/30/06 23:50:47 changed by mdawaffe

  • milestone set to 2.1.

Related: #2840.

12/01/06 10:35:44 changed by matt

  • milestone changed from 2.1 to 2.2.

02/23/07 04:14:44 changed by rob1n

  • keywords deleted.
  • owner changed from mdawaffe to rob1n.
  • status changed from new to assigned.

02/23/07 23:53:32 changed by rob1n

  • version changed from 2.0.1 to 2.1.

Working on refreshing old patch.

02/24/07 00:25:06 changed by rob1n

  • attachment 2485.diff added.

02/24/07 00:25:46 changed by rob1n

  • keywords set to has-patch.

02/24/07 00:59:29 changed by rob1n

  • attachment 2485.2.diff added.

Adds have_comment(), the_comment and a bunch of WP_Query stuff, including the original patch. *needs testing*

02/24/07 01:23:21 changed by rob1n

  • keywords changed from has-patch to has-patch needs-testing.

02/24/07 02:03:44 changed by mdawaffe

  • attachment 2485.3.diff added.

02/24/07 02:05:34 changed by mdawaffe

2485.3.diff

  1. All of rob1n's 2485.2.diff (rob1n: please verify)
  2. Get rid of some parse errors.
  3. Get rid of have_posts() (I don't think it's necessary) and use have_comments().
  4. Somewhat better comments feed titles.

02/24/07 06:16:58 changed by rob1n

Looks good. I think this is ready for commit?

02/24/07 07:33:33 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4934]) Comment feeds everywhere. Props mdawaffe and rob1n. fixes #2485