Ticket #2550 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

remove smilies uksort

Reported by: random Assigned to: markjaquith
Priority: low Milestone:
Component: Optimization Version: 2.0.1
Severity: trivial Keywords: smilies
Cc:

Description

The sort of the smilies array in vars.php is slow and pointless. It's adding ~1.5% overhead to every page load on my stock install.

As far as I can tell, it just rearranges the array on the off chance that a) you happen to display the smilies in a row with (e.g.) wp-grins, and b) you actually care what order they appear in. That isn't most people, and it can be done in a plugin besides.

See also #213: even if smilies stay in the core, they don't need to be editable by adding functions to wp-config.php, especially when the result is a slower WordPress for everybody else.

Attachments

vars.php.diff (0.5 kB) - added by random on 03/09/06 16:39:20.
removes uksort & smiliescmp()

Change History

03/09/06 16:39:20 changed by random

  • attachment vars.php.diff added.

removes uksort & smiliescmp()

03/11/06 04:09:12 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.

Agreed. I've never seen anyone print the list out, so that's something a plugin could handle.

+1

03/14/06 02:33:03 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [3640]) Remove smilies sort. Props random. fixes #2550

04/22/06 00:07:28 changed by ryan

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.1 to 2.0.3.

Reopen for 2.0.3 inclusion.

04/22/06 00:10:15 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [3741]) Remove smilies sort. Props random. fixes #2550

11/30/06 19:41:50 changed by

  • milestone deleted.

Milestone 2.0.3 deleted