Opened 18 years ago
Closed 17 years ago
#2554 closed defect (bug) (fixed)
Comments link title bug
Reported by: | kpumuk | Owned by: | davidhouse |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | 2.0.2 |
Component: | Template | Keywords: | bg|has-patch |
Focuses: | Cc: |
Description
In function comments_popup_link following construction used:
echo ' title="' . sprintf( __('Comment on %s'), $post->post_title ) .'">';
This is incorrect because it's possible to create plugin which filter title (for example, Polyglot)
I think you need to change this to something like:
echo ' title="' . sprintf( __('Comment on %s'), the_title('', '', false) ) .'">';
PS. Please add 2.0.2 version to Version combo box on "Create New Ticket" page.
Attachments (1)
Change History (5)
#2
@
18 years ago
the_title()
echoes, so that's not correct. Using get_the_title()
would be better, but wouldn't fix the issue, because no filters are run on get_the_title()
The best fix might be to switch to get_the_title()
and to create a new get_the_title
filter. The filters on the echo-only functions are rather limited. There are many instances of get_the_something
filters and I'd recommend using those, because they cover both return and echo instances of usage.
Verified in latest (2.0.2).
File: wp-includes/comment-functions.php
Line: 331
Updated Version tag.
Can a dev verify that this is actually supposed to be as kpmunk says?