Ticket #2570 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Comments feed problem in current 2.1-alpha1 (revision 3643)

Reported by: tinyau Assigned to: davidhouse
Priority: normal Milestone: 2.1
Component: General Version: 2.1
Severity: major Keywords: bg|has-patch bg|tested bg|commit
Cc:

Description

I found there are 2 problems of comments feed in the current revision 3643.

1. "All Comments" feed generated the same content as Posts feed.
2. Comments feed of individual posts cannnot show the comments of the posts.

Attachments

2570.diff (422 bytes) - added by davidhouse on 03/16/06 18:43:51.
2570.2.diff (2.3 kB) - added by davidhouse on 03/16/06 19:03:32.

Change History

03/15/06 08:37:43 changed by davidhouse

  • owner changed from anonymous to davidhouse.
  • status changed from new to assigned.

03/16/06 18:43:51 changed by davidhouse

  • attachment 2570.diff added.

03/16/06 18:44:07 changed by davidhouse

  • keywords set to bg|has-patch.

Try that.

03/16/06 19:01:28 changed by davidhouse

Err, never mind, that patch is completely broken. Working on a second.

03/16/06 19:02:51 changed by davidhouse

Try this second one.

03/16/06 19:03:32 changed by davidhouse

  • attachment 2570.2.diff added.

03/16/06 19:14:02 changed by skippy

  • keywords changed from bg|has-patch to bg|has-patch bg|tested bg|commit.

second patch fixes the problem described in the ticket.

03/17/06 01:02:25 changed by ryan

We also need to add $id and $comment to the list of globals in load_template() for back compat.

03/17/06 01:16:25 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [3644]) Comment feed fixes from David House. fixes #2570

03/17/06 07:58:36 changed by davidhouse

Perhaps we could just do the old trick of extract($GLOBALS); to give anything loaded by load_template() global scope.

03/17/06 23:44:39 changed by ryan

Sounds good.