Ticket #2587 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

New template function: wp_list_bookmarks()

Reported by: ryan Assigned to: westi
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: bookmarks lists has-patch
Cc:

Description

wp_list_bookmarks() will replace get_links_list() and get_links(). By default, it should create a list of all bookmarks organized by category. We want to avoid the mistake of hard coding h2s and other formatting, so there should be options for specifying any formatting that should come before and after each category heading. wp_list_bookmarks() should also allow creating a big list of uncategorized bookmarks as well as listing bookmarks in a specific category or set of categories. A stub for wp_list_bookmarks() exists in template-functions-bookmarks.php along with some implementation notes. wp_list_bookmarks() should use get_bookmarks() for querying the DB.

Attachments

2587.wp_list_bookmarks.diff (2.7 kB) - added by westi on 10/01/06 19:16:32.
Implement the rest of wp_list_bookmarks

Change History

03/22/06 22:58:57 changed by MichaelH

Question on this requirement--"as well as listing bookmarks in a specific category or set of categories".

If it's a 'set of categories' does that imply allowing something like 'category=1,4,7,9'? If yes, should get_bookmarks() be changed to handle that?

03/23/06 00:59:58 changed by ryan

Yes and yes.

06/16/06 23:37:19 changed by ryan

[3880] first pass

09/29/06 21:08:58 changed by westi

  • owner changed from anonymous to westi.
  • status changed from new to assigned.

Quite a bit of the support code for this seems in good shape.

I'm working on finishing off coding wp_list_bookmarks against the requirements spec. I'll upload a patch when I've got a bit more finished.

10/01/06 19:16:32 changed by westi

  • attachment 2587.wp_list_bookmarks.diff added.

Implement the rest of wp_list_bookmarks

10/01/06 19:17:09 changed by westi

  • keywords changed from bookmarks lists to bookmarks lists has-patch.

Attached patch implements the rest of wp_list_bookmarks I believe

10/02/06 18:01:17 changed by ryan

(follow-up: ↓ 9 ) 10/11/06 03:03:17 changed by foolswisdom

westi, ryan, is there still more to do for this bug? Or should it be closed?

(in reply to: ↑ 8 ) 10/11/06 12:55:29 changed by westi

Replying to foolswisdom:

westi, ryan, is there still more to do for this bug? Or should it be closed?

I don't think this is complete yet.

I think we now need to move the deprecated functions to deprecated.php and implement them as calls to the new function.

I guess that is why ryan left the ticket open?

12/01/06 02:43:45 changed by matt

  • milestone changed from 2.1 to 2.2.

12/01/06 05:57:31 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from 2.2 to 2.1.

Actually, this is done.