Ticket #2589 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

WP DB Backup core tables should reflect new and deleted tables

Reported by: MichaelH Assigned to: anonymous
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: bg|has-patch bg|tested bg|commit bg|2nd-opinion
Cc:

Description

Add the new 'link2cat' table and delete the old 'linkcategories' table from the "These core WordPress tables will always be backed up:" list in WordPress Database Backup Plugin (wp-db-backup.php).

Attachments

db-backup-plugin_updatedtables.diff (0.7 kB) - added by abhay on 03/22/06 18:40:52.
db-backup-plugin_updated_tables2.diff (1.2 kB) - added by abhay on 03/22/06 22:14:19.
2589.diff (1.7 kB) - added by westi on 03/23/06 21:59:17.
New patch updated to use a single array

Change History

03/22/06 18:39:30 changed by abhay

  • keywords set to bg|has-patch.

Good catch and easy to fix. Patch to come.

03/22/06 18:40:52 changed by abhay

  • attachment db-backup-plugin_updatedtables.diff added.

03/22/06 20:59:10 changed by MichaelH

Thanks abhay, the fix works. I didn't test with Skippy's WP-Cron plugin, but notice there's a reference to tables in the wp-cron-daily function in that plugin. Should that be changed also?

03/22/06 21:22:09 changed by abhay

MichaelH: sorry I can't find the reference. Could you give me a "grep --line-number" ?

03/22/06 21:32:50 changed by MichaelH

Should have done that to begin with--line 869.

03/22/06 22:14:19 changed by abhay

  • attachment db-backup-plugin_updated_tables2.diff added.

03/22/06 22:14:44 changed by abhay

  • keywords changed from bg|has-patch to bg|has-patch bg|needs-testing.

It's alright. I should have caught it. New patch is up.

03/23/06 21:59:17 changed by westi

  • attachment 2589.diff added.

New patch updated to use a single array

03/23/06 22:02:59 changed by westi

  • keywords changed from bg|has-patch bg|needs-testing to bg|has-patch bg|tested bg|commit.

I have tested this and it works fine for me.

The cron list of tables was still missing "link2cat" so i have added that in a new patch and moved this list of tables to a class attribute storing them in an array near the top of the file so they are easy to find for updates and only in one place!

I think this is good to go for commit

03/24/06 00:46:08 changed by MichaelH

  • keywords changed from bg|has-patch bg|tested bg|commit to bg|has-patch bg|tested bg|commit bg|2nd-opinion.

While testing westi's fix on a 2.0.2 to 2.1-alpha1 upgrade, I was reminded that the linkcategories table is being left, intact, on upgrades. With this fix, that table will show in the "You may choose to include any of the following tables" column of WP DB Backup.

Any idea on what to do there, if anything?

Also, any opinion about bumping the Version from 1.7 to 1.7.something?

03/24/06 01:15:40 changed by ryan

Eventually, upgrade will drop the linkcategories table. I've been holding off on dropping the table until the bookmark design settled. That has quieted down though, so maybe the time to drop is near.

03/24/06 01:19:35 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [3657]) Update table list in backup plugin. Props abhay and westi. fixes #2589