Ticket #2595 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Option of "action" with value "update" is being added to options table

Reported by: markjaquith Assigned to: markjaquith
Priority: low Milestone: 2.1
Component: Administration Version: 2.1
Severity: trivial Keywords: has-patch 2nd-opinion
Cc:

Description

the hidden form field on wp-admin/options.php with name "action" and value "update" is causing an option of that name and value to be added to the options table. Oops!

Attachments

kill_action_option.diff (355 bytes) - added by markjaquith on 03/24/06 05:20:38.
Kill the "action" option
these_are_not_options.diff (0.6 kB) - added by markjaquith on 03/25/06 12:34:54.

Change History

03/24/06 05:20:38 changed by markjaquith

  • attachment kill_action_option.diff added.

Kill the "action" option

03/24/06 05:23:06 changed by markjaquith

  • keywords set to has-patch 2nd-opinion.
  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.

Fix unsets $_POST$wpvar?; in the "WP vars to set" loop. Anything that we're running through this loop (only "action") we don't want showing up as an option.

People who already have it added are stuck with it, but it'd be silly to write code to remove it... it does no harm.

03/25/06 12:34:54 changed by markjaquith

  • attachment these_are_not_options.diff added.

03/25/06 12:35:43 changed by markjaquith

New patch adds 'Update' to the list of things to reset, as the submit button was being added to the Options table as well.

10/02/06 19:27:45 changed by markjaquith

Related (duplicate?): #3185

10/04/06 12:18:32 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4332]) Prevent non-option form elements from sneaking in to the options table. fixes #2595

10/04/06 12:19:07 changed by markjaquith

(In [4333]) Prevent non-option form elements from sneaking in to the options table. fixes #2595