Ticket #2693 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Paging broken on Manage Posts

Reported by: ryanscheuermann Assigned to: westi
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: paging has-patch
Cc:

Description

I posted this in wp-testers but it seems no one reads that list anymore...

Using latest trunk code, BTW.

First off, the paging on the Manage Posts admin page is determined by the option "posts_per_page" but the results list is hardcoded to show the Latest 15 posts:

edit.php, line 59: 

   wp('what_to_show=posts&posts_per_page=15&posts_per_archive_page=-1');

So, if I set the "posts_per_page" option to 5 (on Options->Reading) and I have 15 posts, the Manage Posts page allows me to page through 3 pages:

* the first page contains my latest 15 posts * the second page (previous) is blank * the third page (previous) is blank

The other bug is related to Ticket #2578

If I set "show at most N posts" to 0, the Manage->Posts page now displays 15 posts and this error: 

*    Warning*:  Division by zero in *wp-includes\template-functions-links.php* on line *476*

This is also related to Changeset 3694.

Attachments

2693.diff (0.7 kB) - added by Nazgul on 10/02/06 14:13:44.
2693.2.diff (502 bytes) - added by westi on 10/02/06 20:41:40.
Alternative patch - use the query info

Change History

04/25/06 18:22:52 changed by matt

Is this latest trunk? I'm pretty sure I removed paging on the Page page page.

04/25/06 18:29:48 changed by ryanscheuermann

  • summary changed from Paging broken on Manage Pages to Paging broken on Manage Posts.

OMG, my bad, I meant that to be the Manage Posts page is broken! Yeah, you're right, paging on Manage Pages is removed, but paging on Manage Posts is broken. :-) Typo!

10/02/06 14:13:44 changed by Nazgul

  • attachment 2693.diff added.

10/02/06 14:15:12 changed by Nazgul

  • keywords changed from paging to paging has-patch.

I've attached a patch which fixes paging.

The other issue mentioned seems to have been fixed already.

10/02/06 20:25:38 changed by westi

-1 to this patch

I think we still want to show 15 posts.

And you can't treat the translation like that you need to use sprintf or it won't be translateable.

Can we not make this paging work correctly?

10/02/06 20:41:40 changed by westi

  • attachment 2693.2.diff added.

Alternative patch - use the query info

10/02/06 20:42:17 changed by westi

Alternative patch fixes the issue as keeps the paging going on.

10/04/06 07:31:37 changed by westi

  • owner changed from anonymous to westi.
  • status changed from new to assigned.

10/04/06 07:43:25 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4316]) Manage Posts paging fix from Westi. fixes #2693