Ticket #3014 (closed defect: wontfix)

Opened 2 years ago

Last modified 10 months ago

why use the @?

Reported by: Denis-de-Bernardy Assigned to:
Priority: normal Milestone:
Component: Administration Version: 2.0.4
Severity: normal Keywords: needs-patch dev-feedback
Cc:

Description (Last modified by markjaquith)

Pinning down a bug on a customer server lead me to removing an '@': 

Warning: dir() has been disabled for security reasons (...)

The pesky line in question was: 

$themes_dir = @ dir($theme_root);

But there's plenty of other calls to: 

@ dir(...)

Why in the bloody hell would anyone want WordPress to silence this kind of error? It should spit something along the lines of "Your host sucks, change it now."

Change History

08/09/06 12:51:21 changed by markjaquith

  • keywords set to needs-patch.
  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.
  • description changed.
  • milestone set to 2.1.

I agree. And I'll bet Podz agrees too. When we hide the sins of poorly configured servers, we make their shortcomings into WordPress shortcomings in the mind of the people using WordPress, and we create a support burden for something that isn't even our problem.

10/06/06 00:47:57 changed by Nazgul

  • keywords changed from needs-patch to needs-patch dev-feedback.
  • severity changed from major to normal.

I disagree with just throwing the errors, because users will then blame WordPress for throwing those errors, generating just as much of a support burden.

Maybe it's an idea to include some kind of test during the initialization/install process. (Check if dir() is allowed, etc..)

11/30/06 22:21:29 changed by matt

  • milestone changed from 2.1 to 2.2.

03/14/07 15:58:00 changed by m0n5t3r

+1 for making the checks before installing

03/27/07 22:31:03 changed by foolswisdom

  • milestone changed from 2.2 to 2.3.

05/01/07 13:39:32 changed by rob1n

  • owner changed from markjaquith to rob1n.
  • status changed from assigned to new.

09/07/07 02:03:04 changed by markjaquith

  • milestone changed from 2.3 to 2.4 (next).

10/19/07 17:38:38 changed by westi

Pre-flight checks in general are a good idea see #5235

12/19/07 07:27:25 changed by rob1n

  • owner deleted.

We might want to close in deference to #5235, since that would fix this and a host of other pre-flight problems.

01/24/08 17:36:02 changed by Nazgul

  • status changed from new to closed.
  • resolution set to wontfix.
  • milestone deleted.

This ticket has had no real activity for over some time and has been partially superseeded by #5235, so closing as invalid for now.

Feel free to re-open if you have additional patches/information/suggestions/...