Ticket #3051 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

QuickTags now work in Safari browser

Reported by: mattyrob Assigned to: MattyRob
Priority: low Milestone: 2.0.6
Component: Administration Version: 2.0.5
Severity: trivial Keywords: safari quicktags maint-candidate
Cc:

Description

The Safari browser has not behaved as expected when the QuickTags are used. A post at http://www.alexking.org/blog/2006/08/15/safari-cursor-aware/ made me look into the fact that they may now work. I've tested and it now works as expected meaning the disabling code can be removed from admin-functions.

Index: admin-functions.php
===================================================================
--- admin-functions.php	(revision 4106)
+++ admin-functions.php	(working copy)
@@ -1228,8 +1228,6 @@
 }
 
 function the_quicktags() {
-	// Browser detection sucks, but until Safari supports the JS needed for this to work people just assume it's a bug in WP
-	if (!strstr($_SERVER['HTTP_USER_AGENT'], 'Safari')) {
 		echo '
 		<div id="quicktags">
 			';
@@ -1237,7 +1235,7 @@
 		echo '			<script type="text/javascript">if ( typeof tinyMCE == "undefined" || tinyMCE.configs.length < 1 ) edToolbar();</script>
 		</div>
 ';
-	} else echo '
+	echo '
 <script type="text/javascript">
 function edInsertContent(myField, myValue) {
 	//IE support

Attachments

3051-fix.txt (0.7 kB) - added by mattyrob on 08/19/06 08:59:59.
Ticket 3051 diff patch

Change History

08/19/06 08:59:59 changed by mattyrob

  • attachment 3051-fix.txt added.

Ticket 3051 diff patch

09/03/06 19:35:39 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [4164]) Enable quicktags for safari. Props mattyrob. fixes #3051

10/15/06 19:36:50 changed by MattyRob

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.1 to 2.0.5.

Can we get this into 2.0.5?

10/27/06 00:22:53 changed by foolswisdom

  • keywords changed from safari quicktags to safari quicktags maint-candidate.
  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from 2.0.5 to 2.1.

Sorry, too late for 2.0.5

Closing FIXED for trunk.

12/08/06 21:20:47 changed by mattyrob

  • status changed from closed to reopened.
  • version changed from 2.0.4 to 2.0.5.
  • resolution deleted.
  • milestone changed from 2.1 to 2.0.6.

I know I keep asking (God loves a tryer!) - as this missed 2.0.5 but is fixed in [4164] for the trunk.

So, can we get this into 2.0.6 (or 2.0.7)

12/10/06 22:26:42 changed by markjaquith

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [4640]) Enable quicktags for Safari. Props mattyrob. fixes #3051