Ticket #3169 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Cron makes empty argument arrays into array(array()), and then array(array(array())), and so on, upon rescheduling

Reported by: masquerade Assigned to: ryan
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords:
Cc:

Description

The way func_slice_args was used caused some issues. I've done away with it in the patch. Now all the cron functions that will pass along args to their corresponding hooks pass in an array of the args to pass to the callbacks run on the hook, as opposed to adding all those args to the end. I personally think its better this way, but it is API breakage for anyone who might've written a plugin using cron so far (only me probably =D ).

Jibber jabber jibber, patch is attached.

Attachments

psuedo-cron-no-nested-array.2.diff (3.0 kB) - added by masquerade on 09/26/06 04:55:33.

Change History

09/26/06 04:55:33 changed by masquerade

  • attachment psuedo-cron-no-nested-array.2.diff added.

10/08/06 17:35:05 changed by ryan

  • owner changed from anonymous to ryan.

10/08/06 17:50:24 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [4362]) Change cron arg passing. Props masquerade. fixes #3169.

10/08/06 17:51:35 changed by ryan

Do we need to upgrade existing entries in the cron array to get rid of empty array()s? I want to make sure already scheduled future posts will be processed.