Ticket #3181 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

i18n issue in quicktags

Reported by: Nazgul Assigned to: ryan
Priority: normal Milestone: 2.2
Component: Administration Version: 2.1
Severity: minor Keywords: i18n quicktags has-patch
Cc:

Description

The quicktags.js file contains a few hardcoded texts which can't be translated by language packs this way.

A quick scan gives at least the following texts: (line number in brackets) Quick Links (171) Dictionary lookup (263) Close all open tags (264) Enter the URL (369) Enter the URL of the image (381) Enter a description of the image (385)

Attachments

3181.diff (4.2 kB) - added by Sewar on 10/09/06 07:12:36.
3181.2.diff (3.3 kB) - added by Sewar on 12/11/06 10:06:34.
Using js_escape()

Change History

10/02/06 22:13:53 changed by Viper007Bond

  • keywords deleted.
  • type changed from defect to enhancement.
  • severity changed from normal to minor.

Changing it to quicktags.php would be needed (and would be nice). It'd allow us to add in a hook to easily add more simple buttons.

10/03/06 08:02:17 changed by Sewar

  • keywords set to i18n quicktags has-patch.
  • owner changed from anonymous to Sewar.
  • status changed from new to assigned.

10/03/06 17:20:15 changed by foolswisdom

  • type changed from enhancement to defect.

Probably safe to consider this a defect, "hardcoded texts which can't be translated by language packs this way."

10/09/06 07:12:36 changed by Sewar

  • attachment 3181.diff added.

10/09/06 07:13:55 changed by Sewar

"svn mv quicktags.js quicktags-js.php" then apply the patch.

11/19/06 01:27:28 changed by ryan

Use js_escape() instead of addslashes for escaping inside JS.

12/01/06 10:57:09 changed by matt

  • milestone changed from 2.1 to 2.2.

12/11/06 10:06:34 changed by Sewar

  • attachment 3181.2.diff added.

Using js_escape()

12/11/06 11:36:14 changed by Sewar

  • milestone changed from 2.2 to 2.1.

This is like #3224, so it can be go in 2.1

01/07/07 08:53:53 changed by ryan

  • owner changed from Sewar to ryan.
  • status changed from assigned to new.

01/08/07 03:43:12 changed by ryan

  • milestone changed from 2.1 to 2.2.

Moving to php and including wp-config.php means we do a full WP load. That can slow down quicktags load quite a bit. Let's defer this until we can figure out something faster for these cases where we just want some gettext for JS.

03/27/07 19:35:51 changed by foolswisdom

  • milestone changed from 2.2 to 2.3.

04/04/07 21:01:47 changed by Nazgul

  • status changed from new to closed.
  • resolution set to fixed.

Fixed by [5167]

04/12/07 06:19:20 changed by rob1n

  • milestone changed from 2.3 to 2.2.