Ticket #3233 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

'Editor' tab title needs clarifier for translation

Reported by: foolswisdom Assigned to: foolswisdom
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords:
Cc:

Description

Stefano wrote to wp-testers Oct 12, 2006 3:12 AM

Subject: [wp-testers] i18n issue

The RTE tab is named Editor, but this string is used for a role too, so the translation for both is unique, in Italian but i suppose in other languages the role is translated in a different way than the RTE's name.

Attachments

3233.patch (0.8 kB) - added by foolswisdom on 10/12/06 22:25:06.
Include HTML comment as proposed by MarkJaquith?
3233-2.patch (1.0 kB) - added by foolswisdom on 11/08/06 02:04:48.

Change History

10/12/06 22:25:06 changed by foolswisdom

  • attachment 3233.patch added.

Include HTML comment as proposed by MarkJaquith?

10/12/06 22:40:19 changed by Viper007Bond

  • keywords set to has-patch.
  • version set to 2.1.
  • milestone set to 2.1.

10/13/06 02:52:07 changed by andy

I dig it

10/13/06 03:42:46 changed by markjaquith

Ryan Boren says on wp-hackers:

Maybe use a custom tag that is stripped by () and _e(). Translators can leave the tag in the translated text or omit it.

_e('Editor<wp:i18n_context>Tab</wp:i18n_context>');

10/13/06 06:33:06 changed by foolswisdom

  • keywords deleted.

Oops, did not mean to add has-patch until after I tested. I should not have attached it I guess, or put in a comment right away.

HTML comment solution does not work, shows up on label. Guess input value can't include comments. Maybe can be escaped, but Ryan's solution seems more elegant and generalizes.

10/13/06 08:09:52 changed by matt

I know we had a reason for choosing "editor" but given its existing context within WordPress as a publishing system perhaps we should reconsider that choice?

Personally I would be fine with Visual / Code or Visual / HTML.

I'm not a fan of adding another layer of compexity to our translation system.

10/13/06 17:15:39 changed by foolswisdom

In light of everything, "Visual" seems like a win/win/win. I am indifferent whether the other is "Code" or "HTML".

11/08/06 01:58:00 changed by foolswisdom

  • owner changed from anonymous to foolswisdom.

No longer indifferent as RTE are often referred as HTML editor (gmail for example), so Visual / Code seems like the winningest to me.

I will attach the trivial patch.

11/08/06 02:04:48 changed by foolswisdom

  • attachment 3233-2.patch added.

11/17/06 21:16:19 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [4476]) Visual and Code. Props foolswisdom. fixes #3233