Ticket #3246 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

make menu items in menu-headers.php relative

Reported by: bmontgom Assigned to: anonymous
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: SSL dev-feedback
Cc:

Description

The URIs for the menu items in menu-headers.php are not relative URIs. These are the only URIs on the page that are not this way. I've been working on a plugin to allow for the login, register, and admin functions to be done using SSL. It is working, but I had to modify menu-headers.php to make the menu item URIs relative in order to get everything correct. A patch for my changes is attached.

Attachments

menu-header.php.diff (1.4 kB) - added by bmontgom on 10/15/06 00:05:45.
patch for menu-headers.php

Change History

10/15/06 00:05:45 changed by bmontgom

  • attachment menu-header.php.diff added.

patch for menu-headers.php

10/15/06 10:08:13 changed by Sewar

  • keywords set to SSL.

You can use Secure Admin which used in WordPress.Com, see: http://wordpress.com/blog/2006/03/08/secure-blogging/.

10/23/06 20:37:42 changed by foolswisdom

  • keywords changed from SSL to SSL dev-feedback.
  • version set to 2.1.
  • milestone set to 2.1.

ENV: WP trunk svn r4415

With my limited knowledge, I can't think of a negative to having the URLs be relative, and I see a small benefit.

Adding Milestone and putting it to dev-feedback

10/23/06 23:01:32 changed by markjaquith

Only potential downside I can see is that it wouldn't work if there was a WP admin page in a subdirectory of /wp-admin/

Can we think of any case where that would happen? I've certainly never seen it.

11/02/06 01:20:07 changed by matt

No opinion.

11/02/06 06:08:04 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [4443]) Make menu items linked with relative URLs. Props bmontgom. fixes #3246