Ticket #3391 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Can't click Labels for Radio Buttons in Moderation Queue

Reported by: JeremyVisser Assigned to: shorty114
Priority: low Milestone: 2.0.6
Component: Administration Version: 2.0.5
Severity: trivial Keywords:
Cc:

Description

In WordPress 2.0.5, with a comment in the moderation queue, go to WordPress Admin → Manage → Awaiting Moderation (x). Try clicking the labels for the radio buttons "Approve", "Spam", "Delete", "Defer until later". That does not work because the IDs and corresponding label elements do not match.

This problem has been fixed for /trunk/, but the 2.0 branch still has the problem. Attached is a patch to fix the problem.

Attachments

moderation.php.diff (2.7 kB) - added by JeremyVisser on 11/25/06 02:56:31.
Patch for moderation.php to fix radio button labels.

Change History

11/25/06 02:56:31 changed by JeremyVisser

  • attachment moderation.php.diff added.

Patch for moderation.php to fix radio button labels.

(follow-ups: ↓ 2 ↓ 3 ) 11/25/06 03:33:28 changed by shorty114

  • owner changed from anonymous to shorty114.
  • priority changed from normal to low.
  • status changed from new to assigned.
  • severity changed from minor to trivial.
  • type changed from defect to enhancement.

I don't this is *absolutely necessary* for 2.0... 2.1 is coming out in ~2 months, can people live without it until then? ;)

Also, I would put the <label> wrapped *around* the input. Can't remember why though.

(in reply to: ↑ 1 ) 11/25/06 03:39:26 changed by shorty114

Replying to shorty114:

I don't this is *absolutely necessary* for 2.0... 2.1 is coming out in ~2 months, can people live without it until then? ;) Also, I would put the <label> wrapped *around* the input. Can't remember why though.

Never mind, this is a good patch.

(in reply to: ↑ 1 ) 11/25/06 04:01:37 changed by JeremyVisser

  • type changed from enhancement to defect.

Replying to shorty114:

Also, I would put the <label> wrapped *around* the input. Can't remember why though.

The reason I didn't do that is because I'm fixing it the same way Matt fixed it for 2.1.

11/25/06 06:37:08 changed by markjaquith

Remember, just because 2.1 is coming out, that doesn't mean 2.0 development is dying! Appreciate that you patched it to sync with 2.1

11/25/06 06:37:27 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4531]) ID fixes to allow label clicking in the moderation queue, from JeremyVisser?. fixes #3391