Ticket #3401 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

raquo should receive gettext treatment

Reported by: ryan Assigned to: rob1n
Priority: normal Milestone: 2.3
Component: Administration Version: 2.1
Severity: normal Keywords:
Cc: nbachiyski

Description

This: 

__('Do it »');

not this: 

__('Do it') . '»'

Attachments

3401.diff (8.6 kB) - added by rob1n on 06/11/07 16:47:23.
bullet-raquos.diff (1.7 kB) - added by nbachiyski on 06/12/07 19:08:06.

Change History

11/29/06 22:00:55 changed by shorty114

I think some langauges actually use this to switch it to «, such as Arabic, since it's right-to-left, so it reverses the ».

12/03/06 21:59:18 changed by matt

  • milestone changed from 2.1 to 2.2.

03/27/07 22:47:38 changed by foolswisdom

  • milestone changed from 2.2 to 2.3.

05/23/07 04:31:26 changed by rob1n

Is this still a matter now? I haven't come across any separated »'s in the code.

05/23/07 06:59:23 changed by nbachiyski

Here is a list of files, in which I found right quotes outside i18n-ed strings: 

wp-admin/admin-functions.php
wp-admin/link-manager.php
wp-admin/post-new.php
wp-admin/options-permalink.php
wp-admin/index.php
wp-admin/upload.php
wp-admin/custom-header.php
wp-admin/page-new.php
wp-admin/upload-functions.php
wp-admin/index-extra.php
wp-content/plugins/akismet/akismet.php

06/02/07 05:15:06 changed by rob1n

  • cc set to nbachiyski.
  • owner changed from anonymous to rob1n.

Those are the ones I could find. Some I had to do <?php _e( '&raquo;' ); ?>, but it shouldn't be any problem to translate.

Look good?

06/11/07 16:47:23 changed by rob1n

  • attachment 3401.diff added.

06/11/07 16:47:59 changed by rob1n

Okay, new patch. Those lone &raquo;s should be taken care of now.

As for the ones on options-permalinks.php, should the whole thing be translated?

06/11/07 21:05:50 changed by rob1n

(In [5676]) Translate &raquo;. see #3401

06/11/07 21:12:11 changed by rob1n

Okay, that was everything but the permalink stuff. What to do about that?

06/11/07 22:43:18 changed by nbachiyski

We should i18n them with a proper description (using _c). I will try to do it tomorrow, when I wake up (1:42 AM here now).

P.S. cc-ing to me by username never worked, I don't know why. When you enter the whole email then it works. Strange one...

P.P.S. Nice patch. Thanks for the time spent :-)

06/12/07 19:07:49 changed by nbachiyski

Here is a sample. If someone can think of better description, it will be gladly accepted :-)

06/12/07 19:08:06 changed by nbachiyski

  • attachment bullet-raquos.diff added.

06/12/07 21:39:23 changed by rob1n

Maybe something more related to the permalinks?

06/13/07 00:45:23 changed by nbachiyski

The use in this context has nothing to do with permalinks. Will the fact that the string is used around permalinks settings affect the way a translator will translate it?

06/13/07 16:28:52 changed by rob1n

Ah, true.

06/13/07 16:29:56 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5696]) Translate the rest of the &raquo;'s. Props nbachiyski. fixes #3401