Ticket #3452 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

xmlrpc uploads do not have attachment metadata.

Reported by: mdawaffe Assigned to: mdawaffe
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch 2nd-opinion
Cc:

Description

Files uploaded through xmlrpc don't show up all pretty like in the upload viewer.

Attached:

  1. Moves wp_create_thumbnail() to functions.php
  2. new function wp_generate_thumbnail_metadata()
  3. Uses that new function.

This has the side effect of creating thumbnails for all xmlrpc uploaded images.

Marking milestone as 2.1. Thoughts?

Attachments

3452.diff (9.4 kB) - added by mdawaffe on 12/07/06 20:11:24.

Change History

12/07/06 20:11:24 changed by mdawaffe

  • attachment 3452.diff added.

12/07/06 20:11:35 changed by mdawaffe

  • owner changed from anonymous to mdawaffe.
  • status changed from new to assigned.

12/07/06 21:14:18 changed by westi

From a quick review this looks nice.

Could we consider adding a filter to wp_create_thumbnail on the new sizes we have computed passing enough data to allow a plugin to change the sizes before we create the thumbnail?

12/07/06 21:21:21 changed by mdawaffe

#3446 - duplicate ticket (sorry) different fixes.

This patch fixes the function, the other addresses the function call.

12/07/06 21:30:47 changed by Nazgul

I think you meant #3453 is a duplicate of #3446, not this one (#3452)

12/07/06 22:42:31 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4628]) Create attachment metadata for xmlrpc uploads. Props mdawaffe. fixes #3452

12/07/06 22:45:48 changed by mdawaffe

Nazgul - yes, thanks :) I are smart.