Ticket #3464 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Category delete AYS prompt incorrectly states outcome of category deletion

Reported by: markjaquith Assigned to: rob1n
Priority: low Milestone: 2.2
Component: Administration Version: 2.1
Severity: minor Keywords: has-patch commit
Cc:

Description

When deleting a category using AJAX, the AYS prompt tells the user that all the posts will go into the default post category and all links will go into the default link category. This is only the case if the deleted category was the only category for that post.

Not sure if it's worth making that distinction in the AYS or if there's even a good way to word such a thing.

"All posts that were only assigned to this category will be assigned to the "Uncategorized" category. All links that were only assigned to this category will be assigned to the "Blogroll" category" ?

Attachments

cat-delete-ays.png (25.4 kB) - added by markjaquith on 12/10/06 21:00:48.
screenshot of AYS
cat-delete-note.png (8.3 kB) - added by markjaquith on 12/10/06 21:01:32.
category delete note
cat-delete-ays.diff (2.8 kB) - added by postalservice14 on 12/15/06 23:31:34.
Patch file
3464.diff (2.9 kB) - added by rob1n on 03/13/07 03:51:54.
3464.2.diff (2.9 kB) - added by rob1n on 03/13/07 04:02:16.
Change bookmarks to links.

Change History

12/10/06 21:00:48 changed by markjaquith

  • attachment cat-delete-ays.png added.

screenshot of AYS

12/10/06 21:01:32 changed by markjaquith

  • attachment cat-delete-note.png added.

category delete note

12/10/06 21:02:07 changed by markjaquith

Actually, look at the cat-delete-note.png attachment... there is also an HTML note that incorrectly states the outcome.

12/15/06 23:28:24 changed by postalservice14

  • owner changed from anonymous to postalservice14.
  • status changed from new to assigned.

12/15/06 23:31:34 changed by postalservice14

  • attachment cat-delete-ays.diff added.

Patch file

12/15/06 23:34:15 changed by postalservice14

  • status changed from assigned to closed.
  • resolution set to fixed.

Let me know if you think the wording should be any different.

John

12/16/06 00:14:07 changed by foolswisdom

  • keywords set to has-patch commit.
  • status changed from closed to reopened.
  • resolution deleted.

Hi John,
Thanks for the patch, don't market tickets fixed though. Someone with commit access will when a fix is checked in.
Wording looks good.

12/16/06 00:24:05 changed by markjaquith 

Instead, posts only in the deleted category are set to the category <strong>%s</strong> and links only set to this category are set to <strong>%s</strong>

I'm not 100% on this. How about: 

Instead, posts that were only assigned to the deleted category are set to the category <strong>%s</strong> and links that were only assigned to the deleted category are set to <strong>%s</strong>

That makes the wording more consistent with the wording in the JS alert() portion of your patch, which I like.

02/05/07 19:25:09 changed by foolswisdom

  • keywords deleted.

03/10/07 17:56:53 changed by rob1n

  • owner changed from postalservice14 to rob1n.
  • status changed from reopened to new.

03/10/07 17:57:24 changed by rob1n

  • status changed from new to assigned.

I'll work on a new patch incorporating MarkJaquith?'s fixes, as the reporter seems to be MIA.

03/13/07 03:51:54 changed by rob1n

  • attachment 3464.diff added.

03/13/07 03:52:18 changed by rob1n

  • keywords set to has-patch commit.

Patch refreshed.

03/13/07 03:59:29 changed by ryan

I think there are some bookmark references lingering. Let's change those to links.

03/13/07 04:00:16 changed by rob1n

  • keywords deleted.

On it.

03/13/07 04:02:16 changed by rob1n

  • attachment 3464.2.diff added.

Change bookmarks to links.

03/13/07 04:02:44 changed by rob1n

  • keywords set to has-patch commit.

03/13/07 23:54:48 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5033]) Rephrase category delete AYS prompt. Props rob1n. fixes #3464