Ticket #3596 (closed defect: invalid)

Opened 2 years ago

Last modified 9 months ago

Manage>Uploads Single Image View's wide image Input boxes are Too Small

Reported by: ryanfitzer Assigned to: mdawaffe
Priority: high Milestone:
Component: Administration Version: 2.1
Severity: normal Keywords: invalid
Cc: andy

Description (Last modified by foolswisdom)

When managing an image via the Manage>Uploads single-image-view screen, if the image is too wide it squishes the URL, Title and Description input boxes to where they are unusable.

Attachments

screengrab.jpg (237.9 kB) - added by ryanfitzer on 01/16/07 21:53:38.
screenshot of problem
3596.diff (1.6 kB) - added by mdawaffe on 01/17/07 22:44:19.
3596b.diff (1.6 kB) - added by mdawaffe on 01/18/07 23:27:04.

Change History

01/16/07 21:53:38 changed by ryanfitzer

  • attachment screengrab.jpg added.

screenshot of problem

01/16/07 21:56:56 changed by ryanfitzer

  • version set to 2.1.

This is in 2.1 beta 4

01/16/07 23:04:34 changed by foolswisdom

  • owner changed from anonymous to mdawaffle.
  • description changed.
  • summary changed from Manage>Uploads Single Image View's Input boxes are Too Small to Manage>Uploads Single Image View's wide image Input boxes are Too Small.

01/17/07 01:44:26 changed by mdawaffe

  • owner changed from mdawaffle to mdawaffe.

waffe - no syrup needed.

01/17/07 22:43:54 changed by mdawaffe

I need more info about this bug.

For that file, was a thumbnail actually created? It would be in the same place on your server as the original but probably called whatever.thumbnail.jpg instead of whatever.jpg (the original).

I've attached a patch which may solve this problem.

01/17/07 22:44:19 changed by mdawaffe

  • attachment 3596.diff added.

01/17/07 23:34:44 changed by mdawaffe

  • keywords changed from manage image to manage image has-patch commit.
  • status changed from new to assigned.

01/18/07 04:09:00 changed by ryanfitzer

Yes, thumbnails were created for the images. The images were no larger than 780px wide (landscape format) when uploaded. I witnessed this in FF 2 on OSX 10.3.9 using a localhost environment via MAMP.

01/18/07 05:37:43 changed by mdawaffe

Do you have the ability to apply the patch above called 3596.diff? If so, does it help with this issue or the other issue you reported (#3597 - I think they are related)?

Can you also do the following debugging for me?

From your screengrab, it seems as though the image with ID = 9 is one for which this problem occurs. Do you have CocoaMySQL or PHPMyAdmin installed or some otherway to look at the raw database? If so, in your _postmeta table, find all the rows with post_id = 9 and paste each here.

We will figure this out :)

01/18/07 10:43:50 changed by mdawaffe

  • priority changed from normal to high.

01/18/07 17:22:08 changed by ryanfitzer

All this is doable. I won't be able to get at the computer (work computer) until tomorrow as I'm stuck at home sick. I'll get you everything The morning of the 19th.

01/18/07 23:27:04 changed by mdawaffe

  • attachment 3596b.diff added.

01/19/07 00:19:05 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4767]) Upload manager image viewer fixes from mdawaffe. fixes #3596

01/19/07 18:50:51 changed by mdawaffe

  • status changed from closed to reopened.
  • resolution deleted.

I'm not convinced this is fixed yet. Anyone seeing this problem please include the debugging info I mentioned above.

01/21/07 05:41:15 changed by ryanfitzer

Sorry, haven't had a chance to implement this. Still recovering. First chance I get I'll post back.

01/24/07 03:43:47 changed by foolswisdom

  • owner changed from mdawaffe to ryanfitzer.
  • status changed from reopened to new.
  • milestone changed from 2.1 to 2.2.

01/26/07 19:17:30 changed by ryanfitzer

  • keywords changed from manage image has-patch commit to patch tested-problem still exists.

I'm gettin' back to normal here. Sorry for the delay.
Plugged in 4767 to upload-functions.php. WP is finding the thumbs just fine on images uploaded after the upgrade from 2.0.x to 2.1. Images uploaded while using 2.0.x are still being shown using the full image, therefore, collapsing the input boxes according to the dimensions of the images.

Requested Database Lines:

INSERT INTO wp_postmeta VALUES (26, 9, '_wp_attached_file', '/homepages/30/d174426947/htdocs/wp-content/uploads/2007/01/primedwall.jpg');

INSERT INTO wp_postmeta VALUES (27, 9, '_wp_attachment_metadata', 'a:5:{s:5:"width";i:780;s:6:"height";i:585;s:14:"hwstring_small";s:23:"height=''96 width=128";s:4:"file";s:78:"/homepages/30/d174426947/htdocs/wp-content/uploads/2007/01/primedwall.jpg";s:5:"thumb";s:24:"primedwall.thumbnail.jpg";}');

01/27/07 01:50:20 changed by foolswisdom

  • owner changed from ryanfitzer to mdawaffe.

04/12/07 18:12:11 changed by foolswisdom

  • keywords changed from patch tested-problem still exists to needs-patch.
  • milestone changed from 2.2 to 2.3.

09/12/07 17:53:29 changed by ryan

  • milestone changed from 2.3 to 2.4 (next).

02/27/08 22:18:17 changed by westi

  • cc set to andy.

I assume this will be fixed in the new uploader.

This appears to be missing functionality at present though.

03/11/08 17:06:45 changed by MtDewVirus

  • keywords changed from needs-patch to invalid.

Using r7236, Manage Media doesn't provide a way to edit anything for the uploads. Basically all you can do is delete, view the posts associated with an upload, or view the uploaded file.

03/11/08 17:29:39 changed by lloydbudd

  • status changed from new to closed.
  • resolution set to invalid.
  • milestone deleted.