Ticket #3665 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

typo in wp-trackback

Reported by: Mittineague Assigned to: markjaquith
Priority: low Milestone: 2.2
Component: General Version: 2.1
Severity: minor Keywords: trackback has-patch
Cc:

Description

This doesn't seem to be causing any problems, but it doesn't look right. (my comment added) 

if (empty($title) && empty($tb_url) && empty($blog_name)) {
	// If it doesn't look like a trackback at all...
	wp_redirect(get_permalink($tb_id));
	exit;
}
/** second !empty($tb_url) is unecessary, SHOULD BE $blog_name or ?? **/
if ( !empty($tb_url) && !empty($title) && !empty($tb_url) ) {
	header('Content-Type: text/xml; charset=' . get_option('blog_charset') );

Attachments

wp-trackback.php.diff (471 bytes) - added by markjaquith on 01/25/07 00:02:47.

Change History

01/25/07 00:02:35 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.
  • milestone changed from 2.3 to 2.2.

It looks like it should be $blog_name

But according to the TrackBack? spec, blog_name, excerpt, and title are all optional. The only required field is url

For now, I'd just remove the redundant check.

01/25/07 00:02:47 changed by markjaquith

  • attachment wp-trackback.php.diff added.

01/25/07 00:03:19 changed by markjaquith

  • keywords changed from trackback to trackback has-patch.

Patch removes redundant check. Does not change functionality.

01/25/07 02:04:36 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4801]) Remove redundant check. Props Mittineague. fixes #3665