Ticket #3692 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[4798] breaks some option usage scenarios including permalinks.

Reported by: westi Assigned to: westi
Priority: normal Milestone: 2.2
Component: Administration Version: 2.2
Severity: normal Keywords: commit
Cc:

Description

[4798] Breaks the page permalinks on my test blog.

When you update the permalinks on option-permalinks the following happens:

  1. delete_option is called for 'page_uris'.
  2. update_option is called for 'page_uris'.
  3. This calls into get_option which marks the option as non-existent
  4. Then this calls add_option (as the option didn't exist) which adds the option to the db
  5. Then update_option returns.

Patch to fix attached This means we have the option in the db (and cache) but we also have cached that the option doesn't exist.

get_option listens to the notoption cache above all else so we can no longer access the option!

Attachments

2268-fixup.diff (0.7 kB) - added by westi on 01/26/07 23:13:54.
Fixup add_option to clear the notoption cache

Change History

01/26/07 23:13:54 changed by westi

  • attachment 2268-fixup.diff added.

Fixup add_option to clear the notoption cache

(follow-up: ↓ 4 ) 01/27/07 00:12:13 changed by Makki

This resolved my problem with permalinks. thank you

01/27/07 06:28:51 changed by foolswisdom

  • version set to 2.2.

01/27/07 10:55:35 changed by westi

  • owner changed from west to westi.
  • status changed from new to assigned.

(in reply to: ↑ 1 ) 01/27/07 10:57:17 changed by westi

Replying to Makki:

This resolved my problem with permalinks. thank you

I assume you are referring to #3686?

This issue only affects trunk (2.2-bleeding) and not 2.1 you really shouldn't be running your blog on 2.2-bleeding.

01/27/07 23:06:48 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4820]) Have add_option() for options whose non-existence has been cached clear that cached non-existence before adding the option. Nice catch by Westi. fixes #3692

01/30/07 01:43:43 changed by ryan

(In [4831]) Remove notoptions caching. Multile rewrite_rules options were being created. See #3692 #2268