Ticket #3753 (reopened enhancement)

Opened 2 years ago

Last modified 1 year ago

Kubrick should allow comments for pages if check marked

Reported by: Coolkevman Assigned to: anonymous
Priority: normal Milestone: 2.9
Component: Template Version: 2.1
Severity: normal Keywords: theme kubrick page has-patch
Cc:

Description

Wordpress allow comments on pages. Everything in the code or the user interface indicate this.

Unfortunately it's impossible to add comments on a static page that allow them. At least it's impossible "out of the box" with default (aka Kubrick) theme.

My trivial patch add a comment form and comment list on every static page diplayed in Kubrick theme. This patch was tested on Wordpress 2.0.x and 2.1.

Attachments

wp-default-theme-show-comments-on-pages.diff (298 bytes) - added by Coolkevman on 02/06/07 15:05:38.
Patch to display comments on static page with Kubrick theme.
wp-default-theme-show-pages-comments-or-pingbacks.diff (460 bytes) - added by Coolkevman on 03/11/07 18:12:38.
Fix diff path. Sorry.

Change History

02/06/07 15:05:38 changed by Coolkevman

  • attachment wp-default-theme-show-comments-on-pages.diff added.

Patch to display comments on static page with Kubrick theme.

02/06/07 19:28:08 changed by foolswisdom

  • keywords changed from theme, kubrick, page, comment to theme, kubrick, page, has-patch, comment.
  • summary changed from Hidden coments on static pages to Kubrick should allow comments for pages if check marked.

ENV: WP trunk (2.2-bleeding) r7842
Confirmed bug
Tested patch.

Coolkevman, Thank you! in the future please provide patches from the root of the project, so instead of the page file being for 'page.php' it is for 'wp-content/themes/default/page.php'

02/21/07 15:32:25 changed by Nazgul

  • type changed from defect to enhancement.
  • milestone changed from 2.1.1 to 2.2.

(follow-up: ↓ 4 ) 02/23/07 01:14:46 changed by foolswisdom

  • keywords changed from theme, kubrick, page, has-patch, comment to theme, kubrick, page.
  • status changed from new to closed.
  • resolution set to wontfix.
  • milestone deleted.

Close WONTFIX.

Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)

(in reply to: ↑ 3 ) 03/11/07 18:07:54 changed by Coolkevman

Replying to foolswisdom:

Close WONTFIX. Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)

Ok, so if I understand a patch like the one I've just uploaded (wp-default-theme-show-pages-comments-or-pingbacks.diff) is not acceptable ?

03/11/07 18:12:38 changed by Coolkevman

  • attachment wp-default-theme-show-pages-comments-or-pingbacks.diff added.

Fix diff path. Sorry.

12/16/07 21:51:39 changed by darkdragon

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to 2.5.

Reopening for 2.5 to allow for patch to be debated again.

12/16/07 21:52:11 changed by darkdragon

  • keywords changed from theme, kubrick, page to theme kubrick page has-patch.