Ticket #3787 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

comments.php template validation broken

Reported by: tandilboy Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: Template Version: 2.1
Severity: normal Keywords: has-patch commit
Cc:

Description

w3c validator shows this error 

Error Line 122 column 13: syntax of attribute value does not conform to declared value.
		<li class="" id="comment-1869">

The value of an attribute contained something that is not allowed by the specified syntax for that type of attribute. For instance, the “selected” attribute must be either minimized as “selected” or spelled out in full as “selected="selected"”; the variant “selected=""” is not allowed.

Attachments

3787.diff (1.1 kB) - added by rob1n on 02/14/07 03:29:16.
3787.2.diff (1.1 kB) - added by rob1n on 02/21/07 02:00:25.
3787.3.diff (1.1 kB) - added by rob1n on 02/21/07 06:06:57.

Change History

02/14/07 03:29:16 changed by rob1n

  • attachment 3787.diff added.

02/14/07 03:30:26 changed by rob1n

  • keywords set to has-patch commit.
  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.

Patch 3787.diff does a simple hack, works as advertised.

Validation was screwed up because on the non-highlighted comments (every other), class="" was the class attribute, and apparently empty attributes aren't valid.

02/15/07 21:57:51 changed by rob1n

  • milestone changed from 2.1.1 to 2.2.

02/21/07 02:00:25 changed by rob1n

  • attachment 3787.2.diff added.

02/21/07 02:00:44 changed by rob1n

Added a new patch which uses ryan's idea of cleaner coding.

Ryan++.

02/21/07 06:06:57 changed by rob1n

  • attachment 3787.3.diff added.

02/21/07 06:07:26 changed by rob1n

Latest patch incorporates MarkJaquith?'s recommendation of making the code even more compact.

02/23/07 00:55:54 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4922]) Don't emit empty class. Props rob1n. fixes #3787