Ticket #3788 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Upgrade to TinyMCE 2.1.0

Reported by: Nazgul Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch commit
Cc:

Description

TinyMCE 2.1.0 Released:

http://tinymce.moxiecode.com/punbb/viewtopic.php?id=6015

Attachments

3788.diff (62.9 kB) - added by rob1n on 04/11/07 00:49:20.
3788.2.diff (55.2 kB) - added by rob1n on 04/12/07 02:19:34.
Andy's changes
Picture 1.png (10.5 kB) - added by rob1n on 04/12/07 02:44:50.
3788.3.diff (53.9 kB) - added by rob1n on 04/12/07 04:30:49.
My latest patch
tiny.diff (50.2 kB) - added by andy on 04/12/07 04:55:50.
My turn.
mce.diff (52.6 kB) - added by andy on 04/12/07 10:11:43.
This one actually looks good.

Change History

02/14/07 15:44:47 changed by foolswisdom

  • owner changed from anonymous to andy.
  • type changed from defect to enhancement.

02/22/07 07:00:22 changed by rob1n

  • keywords changed from tinymce editor wysiwyg rte to tinymce dev-feedback.
  • priority changed from low to normal.

04/10/07 23:51:51 changed by rob1n

  • keywords deleted.
  • owner changed from andy to rob1n.

04/11/07 00:49:20 changed by rob1n

  • attachment 3788.diff added.

04/11/07 00:50:39 changed by rob1n

  • keywords set to has-patch commit.

04/11/07 03:50:10 changed by andy

Thanks for doing that patch! Some issues in the diff that should be fixed before commit:

Changing wp-includes/js/tinymce/plugins/directionality/langs/en.js may break translations.

inlinepopups/editor_plugin.js -287,+392 undoes a WP-specific feature: "close" buttons on the left for macs.

inlinepopups/editor_plugin.js -561,+684 removes a WP focus fix. See comment in source and test.

tiny_mce.js -5186,+5223 might suck.

themes/advanced/jscripts/link.js -25,+25 should not be changed. -58,+57 looks like it'll break anchor-only links people sometimes try to add. I think these are both WP changes.

themes/advanced/link.htm should not be changed. This is WP stuff that sets focus and reverses the button order and kills enter-key submits.

themes/advanced/css/editor_popup.css removes stuff marked as WordPress customizations.

themes/advanced/image.htm changes are all WP custom, shouldn't be changed.

themes/advanced/source_editor.htm same deal.

Updating TinyMCE is probably easier if you patch from a diff between TinyMCE releases. Diffing against WP's implementation requires this kind of attention.

04/12/07 02:19:34 changed by rob1n

  • attachment 3788.2.diff added.

Andy's changes

04/12/07 02:44:50 changed by rob1n

  • attachment Picture 1.png added.

04/12/07 04:30:49 changed by rob1n

  • attachment 3788.3.diff added.

My latest patch

04/12/07 04:55:50 changed by andy

  • attachment tiny.diff added.

My turn.

04/12/07 10:11:43 changed by andy

  • attachment mce.diff added.

This one actually looks good.

04/12/07 10:13:11 changed by andy

mce.diff applies the upgrade and fixes all of the interaction issues I could find. Ready for commit and broader testing.

04/12/07 17:04:11 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5256]) Upgrade TinyMCE to 2.1.0. Props andy. fixes #3788