Javascript should not be localized by via PHP

3911.diff To apply

1. svn mv wp-includes/js/list-manipulation-js.php wp-includes/js/list-manipulation.js

Features

1. wp_localize_script( script_name, JS object_name, array( JS val => localized string ) See listman example in new script-loader.php

Nice

+1 for this. At the moment I have to resort to defining variables in admin_head() and wp_head() which is ugly to say the least.

What object will the passed variables be attached to? (window, or a some other?) It seems to be magically attached to tempobj somehow...?

And in your patch, I didn't quite see what

 - if ( this.theList.childNodes.length % 2 )
 + if ( ( this.theList.childNodes.length + this.altOffset ) % 2 )

did, or whether it was part of the changes?

majelbstoat,

The variables get put into an object you specify. The patch on this ticket tells the script loader to add them to an object called "listManL10n":

wp_localize_script( 'listman', 'listManL10n', array( 
   'jumpText' => __('Jump to new item'), 
   'delText' => __('Are you sure you want to delete this %s?') 
) );

(in the patch the above is actually accomplished by a line that looks like $this->localize( ... );)

Script loader then generates the following output in the page's HEAD.

<script type='text/javascript'>
/* <![CDATA[ */
	listManL10n = {
		jumpText: "Jump to new item",
		delText: "Are you sure you want to delete this %s?"
	}
/* ]]> */
</script>

It's the responsibility of the JavaScript? to then go find it. listMan was tweaked to do just that with the following lines (included in the patch).

if ( 'undefined' != typeof listManL10n ) 
   Object.extend(listMan.prototype, listManL10n);

As to your other question:

Oops, forgot about the offset stuff. I think it fixes a coloring bug that sometimes shows up when AJAX adding new items to a list with alternating colors, but that's been sitting around locally on my machine for a while....

Sweet, I didn't spot the listManL10n object. That's a nice system and will make localisation a lot easier (kind of a special interest of mine).

(In [4968]) JS localization from mdawaffe. fixes #3911