Ticket #3956 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Clean up vars.php

Reported by: rob1n Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: Optimization Version: 2.2
Severity: normal Keywords: has-patch commit
Cc:

Description

vars.php currently:

* Uses 0/1 for false/true. Mark noted in the source with a comment that "we should probably use true/false." 0 and 1 are a bit confusing. * Does preg_match's that really don't need to be regular expressions. strpos() works much faster.

Just some speed ups.

Attachments

3956.diff (2.4 kB) - added by rob1n on 03/11/07 01:15:11.
Clean up of vars.php.

Change History

03/11/07 01:15:11 changed by rob1n

  • attachment 3956.diff added.

Clean up of vars.php.

03/11/07 01:15:33 changed by rob1n

  • keywords set to has-patch.
  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.

03/11/07 01:16:23 changed by rob1n

  • keywords changed from has-patch to has-patch commit.

03/11/07 01:19:18 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5024]) vars.php cleanups and speedups from rob1n. fixes #3956