Ticket #3958 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

New style internationalization of quicktags.js

Reported by: nbachiyski Assigned to: Nazgul
Priority: normal Milestone: 2.2
Component: General Version: 2.2
Severity: normal Keywords: i18n js has-patch
Cc:

Description

quicktags.js should also be i18ned using the new system, devised by mdwaffe.

However we should think of other place for defining the translatable strings, not in script-loader.php, because there could be plenty of them. We can have a separate file for js gettext strings - script-i18n.php.

Attachments

3958.diff (3.8 kB) - added by Nazgul on 04/01/07 00:40:00.
3958b.diff (3.9 kB) - added by Nazgul on 04/01/07 09:47:01.

Change History

03/11/07 23:28:54 changed by nbachiyski

  • keywords set to i18n js.

03/12/07 10:47:53 changed by Sewar

See also #3181

03/12/07 21:20:05 changed by ryan

A separate file is fine.

04/01/07 00:40:00 changed by Nazgul

  • attachment 3958.diff added.

04/01/07 00:41:23 changed by Nazgul

  • keywords changed from i18n js to i18n js has-patch.
  • owner changed from anonymous to Nazgul.
  • milestone changed from 2.3 to 2.2.

04/01/07 04:25:09 changed by ryan

s/Quick Links1/Quick Links/

I think we should attribute_escape() strings that are bound for attributes.

Otherwise, looks good.

04/01/07 09:47:01 changed by Nazgul

  • attachment 3958b.diff added.

04/01/07 09:49:43 changed by Nazgul

  • status changed from new to assigned.

The patch has been updated per ryan's suggestions.

I removed the 1 (wonder how it got in in the first place) and added attribute_escape() to the 4 strings that go into attributes.

04/01/07 16:02:06 changed by ryan

We can handle moving the strings to another file with a new ticket.

04/01/07 16:06:21 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5167]) i18n for quicktags.js. Props Nazgul. fixes #3958