Ticket #3978 (closed enhancement: fixed)

Opened 1 year ago

Last modified 6 months ago

Visual Editor should remember your last tab setting

Reported by: matt Assigned to: mdawaffe
Priority: high Milestone: 2.5
Component: Administration Version: 2.1.2
Severity: minor Keywords: has-patch needs-testing
Cc: rob1n

Description

Whatever tab you're on in the visual editor, be it editor or code, if you leave the page when you load next time the same tab should be auto-selected.

Attachments

3978.diff (8.4 kB) - added by mdawaffe on 01/05/08 23:55:28.
3978b.diff (8.2 kB) - added by mdawaffe on 01/06/08 00:07:39.
fixes bug when default tab is HTML
3978c.diff (8.4 kB) - added by mdawaffe on 01/06/08 00:16:54.
fixes bug when default tab is HTML and you are editing a pre-existing post

Change History

03/16/07 07:36:28 changed by markjaquith

  • keywords set to needs-patch.

+1

Cookie-stored preference should be good enough here. If you want to use something permanently you'd just change the RTE option.

03/31/07 19:47:48 changed by rob1n

  • cc set to rob1n.

IMO this is debatable. It could be expected that you just start with a fresh slate (the default when you have RTE enabled -- the RTE) whenever you load up the writing interface. Besides, if you use the code view most of the time, might as well switch over to it, right?

04/10/07 18:31:09 changed by foolswisdom

  • milestone changed from 2.2 to 2.3.

06/17/07 20:31:13 changed by MellerTime

I like the idea of a cookie preference. Just because you use the code view 99% of the time doesn't mean you should have to go into your profile and flip the RTE back on the 1% of the time you want to use it.

06/17/07 21:13:30 changed by foolswisdom

  • milestone changed from 2.3 (trunk) to 2.4 (future).

+1 MellerTime? completely agree! I regularly end up disabling the Visual to work around a bug or two and then don't re-enable for a long time, because the problems occur when the post is first edited in the TinyMCE.

06/18/07 19:40:22 changed by mdawaffe

#4486 dupe of this ticket

01/05/08 23:55:28 changed by mdawaffe

  • attachment 3978.diff added.

01/05/08 23:59:46 changed by mdawaffe

  • keywords changed from needs-patch to has-patch needs-testing.
  • owner changed from anonymous to mdawaffe.
  • status changed from new to assigned.

3978.diff

  1. Stores editor preference in wordpress_editor_{$user_id} cookie with long expire time.
  2. Loads page with correct editor for that user.
  3. wpSetDefaultEditor( editor ): JS function to set cookie.
  4. wp_default_editor(): PHP function that checks cookie. Is filtered so that a plugin can store this editor preference info in the DB instead of the cookie.

01/06/08 00:07:39 changed by mdawaffe

  • attachment 3978b.diff added.

fixes bug when default tab is HTML

01/06/08 00:16:54 changed by mdawaffe

  • attachment 3978c.diff added.

fixes bug when default tab is HTML and you are editing a pre-existing post

01/06/08 19:01:33 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6567]) Remember last editor chosen. Props mdawaffe. fixes #3978