Ticket #3981 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

Patch: Improve error propagation from newMediaObject failure in xmlrpc.php

Reported by: redsweater Assigned to: anonymous
Priority: high Milestone: 2.1.3
Component: XML-RPC Version: 2.1.2
Severity: normal Keywords: has-patch
Cc:

Description

I'm the developer of MarsEdit, a Mac desktop blogging application that works with WordPress. When my customers have trouble with the "upload image" functionality, the error responses from WordPress are lackluster. I tracked this down to a simple failure case in xmlrpc.php where the verbose error returned by wp_upload_bits is not being propagated out to the response text.

I'm attaching a proposed diff which addresses this. The diff is against /trunk/ as of today, but I would really love to see this integrated into the 2.1.x branch, because it will have a major impact on my customers' ability to debug MarsEdit interoperability with their WordPress blog.

Daniel Jalkut Red Sweater Software

Attachments

xmlrpc.php.diff (0.6 kB) - added by redsweater on 03/16/07 17:44:27.
Diffs to enhance verbose error propagation from newMediaObject failure.

Change History

03/16/07 17:44:27 changed by redsweater

  • attachment xmlrpc.php.diff added.

Diffs to enhance verbose error propagation from newMediaObject failure.

03/16/07 18:36:21 changed by foolswisdom

  • keywords set to has-patch.
  • priority changed from normal to high.
  • milestone changed from 2.3 to 2.2.

03/16/07 22:12:19 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5054]) Improve error propagation from newMediaObject failure in xmlrpc.php. Props Daniel Jalkut (Red Sweater Software). fixes #3981 for 2.2

03/16/07 22:13:03 changed by ryan

(In [5055]) Improve error propagation from newMediaObject failure in xmlrpc.php. Props Daniel Jalkut (Red Sweater Software). fixes #3981 for 2.1

03/16/07 22:15:21 changed by ryan

  • milestone changed from 2.2 to 2.1.3.

This is a small, confined change so let's include it in 2.1.3. 2.1.3 RC2 is coming today. Let's make sure we test this out before 2.1.3 final.