Ticket #3983 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Blogroll link adding should use clean_url()

Reported by: nateomedia Assigned to: rob1n
Priority: normal Milestone: 2.0.10
Component: Administration Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

Image Address under Blogroll > Add Link now appends "http://" to the front of all URL addresses. This thwarts the use of relative links and is a change in behavior from previous versions. There's no good reason for this behavioral change and it should be corrected.

Attachments

3983.diff (0.9 kB) - added by rob1n on 03/21/07 01:43:24.
3983.2.diff (0.9 kB) - added by rob1n on 03/21/07 03:52:23.
Take out empty check.
3983-branch2.0.diff (0.9 kB) - added by rob1n on 03/21/07 04:22:49.
For the 2.0 branch.

Change History

03/17/07 00:07:14 changed by foolswisdom

  • milestone changed from 2.1.3 to 2.2.

03/20/07 17:51:25 changed by foolswisdom

Likely relates to #4001.

03/20/07 18:25:20 changed by rob1n

  • keywords deleted.
  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.

For starters, I don't see *why* you would be using relative URI's in your blogroll, but that aside, I agree that this "default behavior" should be changed.

Also, I think blogrolls should use clean_url() not the plain regex that is on line 614 of admin-functions.php. I'll fix this.

03/20/07 18:26:09 changed by rob1n

  • summary changed from Blogroll Image Address auto inserting "http://" with relative links to Blogroll link adding should use clean_url().

03/21/07 01:43:24 changed by rob1n

  • attachment 3983.diff added.

03/21/07 01:44:00 changed by rob1n

  • keywords set to has-patch.

Patch changes edit_link() (which is called by add_link()) to use clean_url(), and also use clean_url() on the RSS link (if it's not empty).

03/21/07 03:52:23 changed by rob1n

  • attachment 3983.2.diff added.

Take out empty check.

03/21/07 03:52:33 changed by rob1n

  • keywords changed from has-patch to has-patch commit.

03/21/07 03:58:38 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5068]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for trunk

03/21/07 03:59:10 changed by ryan

(In [5069]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for 2.1

03/21/07 04:20:06 changed by ryan

Maybe clean_url only REQUEST_URI, which should begin with a slash, and not clean_url the edit-users.php link.

03/21/07 04:20:39 changed by ryan

Code in question is in user_row() in admin-functions.php BTW. We'll need to check other places too.

03/21/07 04:22:49 changed by rob1n

  • attachment 3983-branch2.0.diff added.

For the 2.0 branch.

03/21/07 04:23:30 changed by rob1n

  • status changed from closed to reopened.
  • version deleted.
  • resolution deleted.
  • milestone changed from 2.2 to 2.0.11.

Reopen for 2.0.

03/21/07 04:28:56 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5070]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for 2.0

03/24/07 17:42:54 changed by rob1n

  • milestone changed from 2.0.11 to 2.0.10.