Ticket #4057 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

Add widgets compatibility to default and classic themes

Reported by: Otto42 Assigned to: rob1n
Priority: normal Milestone: 2.2
Component: Template Version: 2.1.2
Severity: normal Keywords: has-patch commit
Cc:

Description

Widget compatibility really should be in the core code. Just my opinion, but it would save a lot of people a lot of trouble.

Even if we don't move the widgets plugin in as a default included plugin, it would be nice if the core themes were widget-friendly, in the hopes that people making themes will get the hint and make their themes widget friendly as well.

Patch included. It's not exactly the same as the mods that come with the widgets plugin, as I felt it was useful to explicitly specify the before & after bits for each theme in the functions.php files instead of hoping that the defaults for the widgets plugin don't change.

Attachments

themes-widgets.diff (2.2 kB) - added by Otto42 on 03/31/07 14:54:02.
Adds widget support to the default and classic themes.
4057.diff (479 bytes) - added by johnbillion on 04/04/07 00:31:42.
Fix typo in wp-content/themes/classic/functions.php at r5154

Change History

03/31/07 14:54:02 changed by Otto42

  • attachment themes-widgets.diff added.

Adds widget support to the default and classic themes.

03/31/07 15:05:28 changed by Otto42

  • keywords set to has-patch.

03/31/07 16:47:32 changed by rob1n

  • keywords changed from has-patch to has-patch 2nd-opinion.

I recall discussing this with Ryan a few weeks ago and the response was that it wasn't necessary. I'm not sure if that's changed, though it might make a nice addition.

+1.

03/31/07 16:52:22 changed by rob1n

  • keywords changed from has-patch 2nd-opinion to has-patch commit.

Just talked to Matt, and it's going in. Sweet.

03/31/07 16:57:55 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5151]) Add widget support (if plugin is available) to default themes. Props Otto42. fixes #4057

03/31/07 17:29:15 changed by Otto42

  • status changed from closed to reopened.
  • resolution deleted.

You forgot to add the new functions.php file for the classic theme, unless it's in another changeset or I'm stupid and missing something. ;-)

03/31/07 19:50:37 changed by rob1n

  • owner changed from anonymous to rob1n.
  • status changed from reopened to new.

Nah, I'm just an idiot :\.

03/31/07 19:53:01 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5154]) Add classic theme's functions.php. Good eyes, Otto42. fixes #4057

04/04/07 00:31:42 changed by johnbillion

  • attachment 4057.diff added.

Fix typo in wp-content/themes/classic/functions.php at r5154

04/04/07 00:32:03 changed by johnbillion

  • status changed from closed to reopened.
  • resolution deleted.

Just by looking at it, I think there's a typo in /wp-content/themes/classic/functions.php at r5154 on line 2. It should be 

if ( function_exists('register_sidebar') )

and not the plural register_sidebars. Patch attached.

04/04/07 00:47:39 changed by rob1n

  • status changed from reopened to new.

My bad.

04/04/07 00:58:57 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5176]) Fix typo. Props johnbillion. fixes #4057