Ticket #4068 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

View Post Link Issues (RE: Changeset 5159)

Reported by: Viper007Bond Assigned to: rob1n
Priority: low Milestone: 2.2
Component: Administration Version: 2.2
Severity: minor Keywords:
Cc:

Description

RE: [5159]

Oh where to begin...

* The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar:

http://img217.imageshack.us/img217/8155/wpvz4.png

* The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location

* target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

Attachments

preview-link-fix.diff (395 bytes) - added by rob1n on 04/05/07 02:31:58.

Change History

04/05/07 02:03:43 changed by rob1n

(In [5182]) Move inline styles to wp-admin.css. see #4068

(in reply to: ↑ description ) 04/05/07 02:20:20 changed by rob1n

  • keywords deleted.
  • owner changed from anonymous to rob1n.

Replying to Viper007Bond:

RE: [5159] Oh where to begin... * The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar: http://img217.imageshack.us/img217/8155/wpvz4.png

I can reproduce this. Fix coming up in a bit.

* The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location

Fixed in [5182].

* target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

I'll talk to Matt.

04/05/07 02:31:58 changed by rob1n

  • attachment preview-link-fix.diff added.

04/05/07 03:49:12 changed by mdawaffe

We'll need to adjust rtl.css too.

Something like 

a.view-link {
        right: auto;
        left: 2em;
        margin-right: 0;
        margin-left: 19em;
}

For what's currently in trunk. I didn't look at the attached patch :)

04/05/07 04:52:50 changed by rob1n

Ah, I'll do that now.

And the patch doesn't completely work under IE (both 6 and 7). Still "functional," but not perfect ;).

04/05/07 04:54:56 changed by rob1n

(In [5183]) Add RTL support for new view-link class. see #4068

04/05/07 04:55:42 changed by rob1n

As for the target="_blank" thing, I'll talk to Matt about possibly using a JavaScripty? window.open solution. But I'm not overtly concerned about internal HTML validation.

04/06/07 00:38:33 changed by rob1n

(In [5185]) Use fixed widths instead of pixels, so it stays the same at all resolutions. see #4068

04/06/07 03:36:17 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

The target="_blank" can stay as it is.