Ticket #4191 (closed enhancement: fixed)

Opened 1 year ago

Last modified 8 months ago

major rework of wp-app.php

Reported by: eliast Assigned to: ryan
Priority: high Milestone: 2.3
Component: XML-RPC Version:
Severity: normal Keywords: app wp-app atom
Cc: dougal, matt, josephscott

Description

I have a done a ton of rework for the APP implementation. Most importantly, I have broken up the parser from the server.

There are many fixes as a result of the Atom Interop event at Google. But some of them include:

  • Better support for XHTML
  • More complete query results of entries in feed listings
  • Converted tabs to spaces
  • Added support for atom:published
  • Categories support (both XML document and set/update categories)
  • Improved Paging
  • Fixed draft support
  • Improved role/caps support
  • Fixed atomsvc+xml content type
  • Fixed Media Collection urls
  • Tested with our own test suite: http://svn.wp-plugins.org/wp-app/test

That's all for now.

Attachments

wp-app.patch (27.3 kB) - added by eliast on 05/24/07 12:16:09.
atomlib.php (10.1 kB) - added by eliast on 05/24/07 12:16:20.
wp-app.php.diff (33.2 kB) - added by placey on 08/27/07 19:36:20.
Patch to bring wp-app.php up to conformance with final Atompub spec

Change History

04/25/07 04:43:35 changed by rob1n

Just briefly looking at the atomlib.php, it says it requires PHP 5... WP has a minimum requirement of PHP 4.2, I believe.

04/25/07 12:25:50 changed by eliast

rob1n, php5 is a long story. Language-wise it doesn't need php5, but there are differences in XML parsing between 4.2 and 6 that are hard to ignore. This is something we need to decide, although, I have been coding with the lowest common denominator in mind. That said, it works on my dreamhost account with php4.4.2 I think. We can always disable APP support if there's not enough XML support to maintain a stable endpoint. However, that shouldn't stop us from shipping it.

04/25/07 21:46:46 changed by foolswisdom

  • milestone changed from 2.4 to 2.3.

04/29/07 06:15:39 changed by matt

This patch is unreadable because of the needless tab -> spaces changes. Please keep things to WP's coding standards, and try to keep patches as succinct as possible.

05/24/07 12:16:09 changed by eliast

  • attachment wp-app.patch added.

05/24/07 12:16:20 changed by eliast

  • attachment atomlib.php added.

05/24/07 12:19:06 changed by eliast

  • cc changed from dougal to dougal, matt.
  • summary changed from Major rework of wp-app.php to Not so major rework of wp-app.php.

@matt,

I fixed the patch considerably to make it more readable. Please let me know if this is ready to be committed.

@rob1n,

The code has always been the same (so it works on php4). The only reason why I added php5 was because that's the parser I have tested and they do behave differently across versions depending on what you compiled php with. However, I'll work to make sure the XML parsing behavior is consistent across versions.

08/08/07 17:47:41 changed by foolswisdom

Sam Ruby will be reviewing and testing the patch attached here http://intertwingly.net/blog/2007/08/03/WordPress-AtomPub-and-PHP5#c1186424251

08/27/07 06:23:43 changed by josephscott

  • cc changed from dougal, matt to dougal, matt, josephscott.

08/27/07 19:36:20 changed by placey

  • attachment wp-app.php.diff added.

Patch to bring wp-app.php up to conformance with final Atompub spec

08/27/07 19:38:33 changed by placey

  • priority changed from normal to high.
  • summary changed from Not so major rework of wp-app.php to major rework of wp-app.php.

Attached wp-app.php.diff that can be applied against the current version on the trunk. This should bring Atompub support up to the current and final release of the spec, but needs additional testing.

08/27/07 19:52:58 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5951]) Bring in atomlib 0.4 and update wp-app to use it. Props eliast and placey. fixes #4191

(follow-up: ↓ 11 ) 08/27/07 23:57:30 changed by foolswisdom

  • status changed from closed to reopened.
  • resolution deleted.

DD32 to wp-hackers: Might not be a bug, But are you sure you wanted '.*/wp-app.php' ? keeping in mind that str_replace only replaces literals, it doesnt support regular expresions.

(in reply to: ↑ 10 ) 09/05/07 17:03:57 changed by josephscott

  • status changed from reopened to closed.
  • resolution set to fixed.

Replying to foolswisdom:

DD32 to wp-hackers: Might not be a bug, But are you sure you wanted '.*/wp-app.php' ? keeping in mind that str_replace only replaces literals, it doesnt support regular expresions.

This was dealt with in #4887 and committed in [6004].