Ticket #4259 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

Text & page widget improvemets

Reported by: Denis-de-Bernardy Assigned to: rob1n
Priority: normal Milestone: 2.2.2
Component: Administration Version: 2.2
Severity: normal Keywords: has-patch
Cc:

Description (Last modified by rob1n)

XP SP2, IE7

The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.

In addition, please be so kind to apply the attached patch. It does the following:

  1. add an option to wpautop text widgets
  2. add an option to exclude pages from the pages widget
  3. sort page widgets using menu_order rather than by their title

Attachments

widgets.png (67.7 kB) - added by Denis-de-Bernardy on 05/13/07 20:21:06.
widgets.diff (3.5 kB) - added by Denis-de-Bernardy on 05/13/07 20:22:05.
4259.diff (3.8 kB) - added by rob1n on 05/18/07 02:29:25.
page order + text widget filters
page-exclude.diff (2.5 kB) - added by rob1n on 05/31/07 01:56:15.
option to exclude pages

Change History

05/13/07 20:21:06 changed by Denis-de-Bernardy

  • attachment widgets.png added.

05/13/07 20:22:05 changed by Denis-de-Bernardy

  • attachment widgets.diff added.

05/13/07 22:19:59 changed by matt

If your patch doesn't fix the IE7 issue, you should create a new ticket for it, and explain the reasoning behind it.

05/14/07 01:11:26 changed by rob1n

  • owner changed from anonymous to rob1n.
  • status changed from new to assigned.
  • summary changed from Has anyone bothered to test widgets in Internet Explorer? to Text & page widget improvemets.

So your patch doesn't fix errors in IE 7? ...

05/14/07 01:11:35 changed by rob1n

Open another ticket for the IE 7 bug.

05/14/07 01:23:15 changed by rob1n

Also, we should wp_texturize() the text widget's contents.

05/14/07 01:23:19 changed by rob1n

  • keywords set to has-patch.

05/14/07 03:29:57 changed by rob1n

  • priority changed from high to normal.
  • type changed from defect to enhancement.
  • severity changed from blocker to normal.

05/14/07 05:19:48 changed by ryan

wp_list_pages() should sort by menu_order,post_title by default. As for the options, I'd rather wait until 2.2.x. We're planning to add a bunch of options to the widgets.

05/15/07 22:11:48 changed by rob1n

  • milestone changed from 2.2 to 2.2.1.

05/18/07 02:29:12 changed by rob1n

(In [5486]) Texturize and autop the text widgets, and allow pages to be sorted by a specified field. Props Denis de Bernardy. see #4259

05/18/07 02:29:25 changed by rob1n

  • attachment 4259.diff added.

page order + text widget filters

(follow-up: ↓ 12 ) 05/19/07 03:27:55 changed by Denis-de-Bernardy

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

D.

05/19/07 03:41:50 changed by Denis-de-Bernardy

lastly, in the text widget's title, if the title is empty, it is turned into a non-breaking space. this defeats the purpose of:

<?php !empty( $title ) ? print($before_title . $title . $after_title) : null; ?>

D.

(in reply to: ↑ 10 ) 05/19/07 04:04:05 changed by rob1n

Replying to Denis-de-Bernardy:

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

Makes sense. I guess we can make the text widget its own filter.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

Next thing I'm looking at :).

05/21/07 08:13:22 changed by ryan

autop and texturize are breaking the Google Reader Clip snippet. script tags are peed on and the script src is texturized. Since text widgets are commonly used for such snippets, we need to make sure we don't break them.

05/21/07 12:57:45 changed by rob1n

Which brings me back to my original proposal for making texturize/autop a checkbox :).

05/21/07 16:35:39 changed by ryan

Ideally, it should just work.

05/22/07 00:25:44 changed by rob1n

(In [5509]) Don't show title if user leaves it blank. see #4259

05/22/07 21:31:38 changed by ryan

(In [5517]) Remove the_content filter from widget text. see #4259

05/22/07 21:32:07 changed by ryan

(In [5518]) Remove the_content filter from widget text. see #4259

05/22/07 21:34:00 changed by ryan

Some plugins append things to the_content making it unsuitable for widget use. We can add a widget_text or generic text_content filter. I'd like to get autop and texturize playing nicely first.

05/22/07 22:36:57 changed by rob1n

(In [5519]) Run it through the filter. see #4259

05/31/07 01:56:15 changed by rob1n

  • attachment page-exclude.diff added.

option to exclude pages

05/31/07 01:57:10 changed by rob1n

(In [5605]) Add option to exclude pages to pages widget. see #4259

06/02/07 03:05:38 changed by rob1n

  • description changed.

06/08/07 23:09:35 changed by rob1n

  • milestone changed from 2.2.1 to 2.2.2.

(follow-up: ↓ 26 ) 06/11/07 21:13:35 changed by rob1n

Okay, all that's left is autop and texturize.

(in reply to: ↑ description ) 06/11/07 21:33:25 changed by drmike

Replying to Denis-de-Bernardy:

The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.

*chuckle* We have. :)

(in reply to: ↑ 24 ) 08/09/07 19:11:15 changed by foolswisdom

  • milestone changed from 2.2.2 to 2.2.3.

Replying to rob1n:

Okay, all that's left is autop and texturize.

Maybe, open a new ticket and close this one b/c it is in a released version?

08/29/07 18:02:48 changed by foolswisdom

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from 2.2.3 to 2.2.2.

Closing as fixed.