Ticket #4302 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

HTML in text widgets reloaded incorectly in sidebar admin

Reported by: LiamJ Assigned to: rob1n
Priority: normal Milestone: 2.2.1
Component: Administration Version: 2.2
Severity: normal Keywords: text widget xhtml compliance has-patch commit
Cc:

Description

When I visit the sidebar widget admin page and my text widget contents is reloaded from the database all the &s I had in the link text within it are retrieved as normal &s (and I assume the same applies for other tags like this?).

For example, if I'd originally entered part of my text as this;

<a href="http://www.example.com/?prop1=something&amp;prop2=somethingelse">

The sidebar admin page would be reloading it from the database like this;

<a href="http://www.example.com/?prop1=something&prop2=somethingelse">

Thus, unless I re-correct the text widget each time I go in there I end up saving a non-XHTML compliant contents to the text widget. Oh, and this is happening on load, not save. If I save after correcting the contents my generated pages are XHTML compliant.

Attachments

format_to_edit.diff (0.7 kB) - added by ryan on 05/21/07 08:45:19.
Pass widget text through format to edit

Change History

05/21/07 08:45:19 changed by ryan

  • attachment format_to_edit.diff added.

Pass widget text through format to edit

05/21/07 08:45:45 changed by ryan

The text wasn't being formatted for editing. Try that patch.

05/21/07 08:45:56 changed by ryan

  • milestone set to 2.2.1.

05/21/07 13:07:15 changed by rob1n

  • keywords changed from text widget xhtml compliance to text widget xhtml compliance has-patch.

05/21/07 13:11:41 changed by rob1n

  • keywords changed from text widget xhtml compliance has-patch to text widget xhtml compliance has-patch commit.
  • owner changed from anonymous to rob1n.

I reproduced it, and then applied the patch, which worked.

05/21/07 13:13:23 changed by rob1n

  • status changed from new to closed.
  • resolution set to fixed.

(In [5499]) Pass text widget text through format_to_edit. Props Ryan. fixes #4302